[KDE/Mac] Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

Thu Oct 16 21:16:49 UTC 2014

> On Oct. 15, 2014, 10:07 p.m., Thomas Lübking wrote:
> > Please check https://techbase.kde.org/Policies/Kdelibs_Coding_Style
> 
> René J.V. Bertin wrote:
>     Sure, and guess what I noticed first ;)
>     
>     ```
>     Nobody is forced to use this style, but to have consistent formatting of the source code files it is recommended to make use of it.
>     ```
>     
>     I won't mix and match styles in existing code, trying instead to match the style used "locally" as closely as possible. In files I create from scratch I'd prefer to stick to my own convictions, though - basically the only difference is the absence of a space after a keyword. It's not like that isn't exactly unprecedented ...
> 
> Thomas Lübking wrote:
>     Ok, I oversaw that this is entirely your code.
>     Well if this is actually what makes you happy, that's oc fine. And when you ever should abandon the code, there's luckily always astyle to the rescue :-P
>     
>     > the only difference is the absence of a space after a keyword
>     
>     Not only. You've *sometimes* stuff like
>     ```cpp
>     void foo()
>     {  bar();
>        fooBar();
>     }
>     ```
>     
>     and blanks in braces isn't consistent (or at least I fail to see the pattern) - I frankly thought this was a mixup of xcode and "my first day in vim" ;-)

Nope, I thought I'd been avoiding that habit but it's possible a few (only declarations I hope) slipped through . Can't recall seeing anything making it "not done" in the guidelines though, did I miss it?

- René J.V.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120202/#review68511
-----------------------------------------------------------

On Oct. 16, 2014, 1:26 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120202/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 1:26 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> I'm still working on (the KDE4-based version of) my OS X keychain backend for kwallet. I'm at a point where I think I can present a work-in-progress in an RR because at least one feature has been improved enough to be of interest for everyone, and also because I could use feedback on how to proceed.
> I'm currently focussing on 2 settings that are configured in the kwallet KCM (SystemSettings), and for which I'm working on an implementation not requiring kwalletd and/or DBus.
> 
> - idle time closing of wallets. This feature was not supported in the commited version presented in https://git.reviewboard.kde.org/r/119838/ The present patch adds an idleTimer and a shared lastAccessTime member. The idleTimer is reset each time a client performs one of a series of actions that I count as wallet accesses, and before resetting I update the idle timeout value from KConfig. When the timer fires, the elapsed time is compared to the shared last access time, and if it is >= the timeout, the wallet is closed. This applies only to "KDE keychains", so keychains used by OS X applications should not be affected.
> 
> - "close when last application exits". This requires maintaining a "user list" which keeps track of what application has what wallet open. I've implemented an "internal" version of such a registry, mapping wallet name to application names and the list of wallets they have open (a list of wallet reference, pid per application name). The registry is functional, but I have not yet decided (read: figured out) how to make a distributed representation of it.
> 
> So the work-in-progress concerns the distributed user registry. The idea would be to maintain the registry in shared memory, meaning it'd be reset (= disappear) when the last application exits, contrary to a file which can go stale. This would be simple if QSharedMemory objects could be resized, but apparently they cannot, so I'll have to look at other solutions possibly involving OS X frameworks (NSData and it's non-objectiveC version CFDataRef or CFMutableDataRef might be candidates). Suggestions welcome.
> 
> Other work in progress concerns a less wheel-reinventing approach that builds on kwalletd and DBus. I don't see why the code used in `kwallet.cpp` wouldn't work, but I must still misunderstand its finer details. The present patch contains outcommented code that does indeed cause kwalletd to be launched and slots and signals to become visible e.g. in `qdbusviewer`. But they don't work, which in turn makes the whole kwallet layer dysfunctional. Here too feedback is welcome on how what I'm missing and/or how to get this to work.
> Once kwalletd works, wallet idle timeout closing and closing when the last client exits should work out-of-the-box, or at least I suppose.
> 
> 
> Diffs
> -----
> 
>   kdeui/util/kwallet.h d7f703f 
>   kdeui/util/kwallet_mac.h PRE-CREATION 
>   kdeui/util/kwallet_mac.cpp 8344ebb 
>   kdeui/util/qosxkeychain.h d0934e6 
>   kdeui/util/qosxkeychain.cpp 7cb9a22 
> 
> Diff: https://git.reviewboard.kde.org/r/120202/diff/
> 
> 
> Testing
> -------
> 
> OS X 10.6.8, kdelibs 4.14.1 git/master, KDE/MacPorts 4.12.5 .
> Once finalised, all changes should port easily to KF5's kwallet_mac.cpp .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141016/62129e3f/attachment-0001.html>