[KDE/Mac] Review Request 120580: [OS X] make KWalletD::connectToScreenSaver a stub function

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120580/#review68428
-----------------------------------------------------------


> I'd be interested to know the reason for connecting to the screensaver.

>From the code it looks like KWallet closes all wallets when the screen locks.

- Martin Gräßlin


On Oct. 14, 2014, 1:58 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120580/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 1:58 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDE Runtime.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> OS X doesn't use an X11-based screensaver, and KDE/OS X is not based on X11.
> Until now, kwalletd was built with a MacPorts patch that simply excluded the connectToScreenSaver function from kwalletd.cpp as well as from kwalletd.h because the moc preprocessor doesn't respect the `#ifdef Q_WS_X11` conditional around the function prototype.
> 
> This patch removes the conditional code from the header (leaving it only around the `*screensaver` instance variable, and makes the function a stub on OS X.
> 
> I'd be interested to know the reason for connecting to the screensaver. If it's for idle timing I might be able to port replacement functionality already committed to ktimetracker for that purpose.
> 
> 
> Diffs
> -----
> 
>   kwalletd/kwalletd.h 98651a5 
>   kwalletd/kwalletd.cpp 62fe2b6 
> 
> Diff: https://git.reviewboard.kde.org/r/120580/diff/
> 
> 
> Testing
> -------
> 
> on OS X 10.6.8 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141015/e67ccd81/attachment.html>