[KDE/Mac] Review Request 120559: [OS X] prevent the creation of an X11-based video renderer

[Torrie Fischer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120559/#review68399
-----------------------------------------------------------

Ship it!


Ship It!

- Torrie Fischer


On Oct. 11, 2014, 5:53 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120559/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2014, 5:53 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Phonon Backends.
> 
> 
> Repository: phonon-gstreamer
> 
> 
> Description
> -------
> 
> On OS X, Qt is no longer based on X11, but uses native frameworks to present a Cocoa (or Carbon) based GUI. The X11 version hasn't been maintained since Qt 4.4 or so.
> 
> `DeviceManager::createVideoRenderer` does not take this into account, and if the video sink is set neither to opengl nor to software, it will try to create an ximagesink renderer. In itself this is possible because most OS X installations will have an X11 server installed, which cmake will pick up.
> However, attempting X11 calls will inevitably lead to runtime errors and cause an abort of the client.
> 
> This patch adds an additional compile-time check that deactivates the offending code-path.
> 
> 
> Diffs
> -----
> 
>   gstreamer/devicemanager.cpp 85d8c1e 
> 
> Diff: https://git.reviewboard.kde.org/r/120559/diff/
> 
> 
> Testing
> -------
> 
> Tested on OS X 10.6.8 with kdelibs 4.14.2, phonon 4.7.2 and digikam 4.4.0 as the client.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141014/a0f6e40e/attachment.html>