[KDE/Mac] Review Request 120510: [OS X] make debugger build (and functional = in progress)

[René J.V. Bertin]

> On Oct. 9, 2014, 3:20 p.m., Milian Wolff wrote:
> > debuggers/gdb/stty.cpp, line 166
> > <https://git.reviewboard.kde.org/r/120510/diff/2/?file=317097#file317097line166>
> >
> >     why the change here and below (away from < 0)?

In order not to duplicate more SGI-specific code than necessary. ptyfd is now initialised to -2 in order to distinguish an unintialised value from the error value -1. Checing against <0 evidently still allows to catch invalid descriptors.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120510/#review68158
-----------------------------------------------------------


On Oct. 9, 2014, 3:57 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120510/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 3:57 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> The conditions are united under OS X / Macports to build kdevelop's debugger component: the changes to the CMake files take this into account.
> 
> I have made the required changes in stty.cpp to obtain a pty with r/w permissions - on OS X this is done in a way that shares most code with the SGI code. In order not to duplicate more code than necessary I changed the logic of `ptyfd`'s initial value slightly, allowing to distinguish between uninitialised and error return values.
> 
> One has to install an uptodate gdb version (e.g. through MacPorts) and follow the instructions to give it the required permissions to function. Once that's done, the debugger component starts correctly, and appears to communicate with the gdb ("ggdb") slave process.
> 
> The gdb version in MacPorts does not react to SIGKILL, which is the signal used by KDevelop to interrupt a programme being debugged. I solved that issue by retrieving the debugged application's pid from the gdb output, and sending the signal to that application instead of to gdb.
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/gdb.h 6f99a60 
>   debuggers/gdb/gdb.cpp 68e1768 
>   debuggers/gdb/stty.cpp 736fff4 
>   debuggers/CMakeLists.txt 8fe222c 
>   debuggers/gdb/CMakeLists.txt 3d1125c 
> 
> Diff: https://git.reviewboard.kde.org/r/120510/diff/
> 
> 
> Testing
> -------
> 
> OS X 10.6.8 with kdelibs 4.14.1 and kdesdk git/kde4-legacy . Gdb 7.7.1 from MacPorts, compiled with python 2.7 support.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141009/ef0e8de7/attachment.html>