[KDE/Mac] Review Request 121116: support SelectNone ("Do Nothing") when entering a folder (and after deleting a message)

[Sandro Knauß]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121116/#review70964
-----------------------------------------------------------

Ship it!


Ship It!

- Sandro Knauß


On Nov. 13, 2014, 11:51 nachm., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121116/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2014, 11:51 nachm.)
> 
> 
> Review request for KDE Software on Mac OS X and KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> One of the small details I miss in KMail is a possibility not to do anything, i.e. not select any message when entering (selecting) a folder. Same after deleting a message.
> I noticed today that `MessageList::Core` already had a `PreSelectNone` so it was very easy to add `EnumActionEnterFolder::SelectNone` and a line to the relevant KComboBox.
> 
> I was hoping it'd be as easy to do the same for the action after deleting a message, but I haven't yet been able to determine where that would have to be done. Some guidance would be appreciated - also on how to select this or the standard behaviour.
> 
> 
> Diffs
> -----
> 
>   kmail/ui/miscpagemaintab.ui db7aa7c 
>   kmail/kmmainwidget.cpp 5ed9781 
>   kmail/settings/kmail.kcfg.cmake 2f4a8df 
> 
> Diff: https://git.reviewboard.kde.org/r/121116/diff/
> 
> 
> Testing
> -------
> 
> On KUbuntu 14.04 and Mac OS X 10.6.8 (with KDE PIM 4.13)
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141126/68c208ae/attachment.html>