[KDE/Mac] Review Request 121213: [OS X] correctly parse backtrace for demangling symbols

[René J.V. Bertin]

> On Nov. 23, 2014, 12:20 a.m., Thomas Lübking wrote:
> > kdecore/io/kdebug.cpp, line 710
> > <https://git.reviewboard.kde.org/r/121213/diff/1/?file=329504#file329504line710>
> >
> >     likewise.
> >     
> >     Also maybe only have one block that defines
> >     
> >     #if
> >     const char mangleStartIndicator[2] = " _";
> >     const char mangleEndIndicator[3] = " + ";
> >     #else
> >     ..
> >     #endif
> >     
> >     but first check on the need for a "different" end indicator.

This is going to require some research, but I'm not convinced that this bit of code can depend only on the compiler and not on the platform. It's not the mangled system that's different (or if it is, that's taken care of by __cxa_demangle), but the backtrace printout.

Is it really worth it here to introduce constants to define the start and end tokens?


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121213/#review70796
-----------------------------------------------------------


On Nov. 23, 2014, 12:02 a.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121213/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2014, 12:02 a.m.)
> 
> 
> Review request for KDE Software on Mac OS X and kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This patch adapts the parser in `maybeDemangledName` to the backtrace obtained in `kRealBacktrace` on OS X.
> 
> 
> Diffs
> -----
> 
>   kdecore/io/kdebug.cpp 872a05a 
> 
> Diff: https://git.reviewboard.kde.org/r/121213/diff/
> 
> 
> Testing
> -------
> 
> Works as expected on OS X 10.9.4 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141124/6dd041eb/attachment.html>