[KDE/Mac] Review Request 121213: [OS X] correctly parse backtrace for demangling symbols
Thomas Lübking
thomas.luebking at gmail.com
Sat Nov 22 23:44:38 UTC 2014
> On Nov. 22, 2014, 11:20 nachm., Thomas Lübking wrote:
> > kdecore/io/kdebug.cpp, line 717
> > <https://git.reviewboard.kde.org/r/121213/diff/1/?file=329504#file329504line717>
> >
> > Why do you need to sharpen the match?
>
> René J.V. Bertin wrote:
> Because otherwise the symbol to be demangled is left with a trailing space, which causes the demangle to fail. Wanna know how I know?
Don't know about the GCC behavior on trailing spaces, but one should probably have some "while (in.at(mangledNameEnd) == ' ') --mangledNameEnd;" loop?
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121213/#review70796
-----------------------------------------------------------
On Nov. 22, 2014, 11:02 nachm., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121213/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2014, 11:02 nachm.)
>
>
> Review request for KDE Software on Mac OS X and kdelibs.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> This patch adapts the parser in `maybeDemangledName` to the backtrace obtained in `kRealBacktrace` on OS X.
>
>
> Diffs
> -----
>
> kdecore/io/kdebug.cpp 872a05a
>
> Diff: https://git.reviewboard.kde.org/r/121213/diff/
>
>
> Testing
> -------
>
> Works as expected on OS X 10.9.4 .
>
>
> Thanks,
>
> René J.V. Bertin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141122/1b0680a5/attachment.html>
More information about the kde-mac
mailing list