[KDE/Mac] Review Request 121213: [OS X] correctly parse backtrace for demangling symbols

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121213/#review70796
-----------------------------------------------------------



kdecore/io/kdebug.cpp
<https://git.reviewboard.kde.org/r/121213/#comment49506>

    "|| defined(__clang__)"?
    Tesing for a specific compiler or a specific OS is certainly wrong.



kdecore/io/kdebug.cpp
<https://git.reviewboard.kde.org/r/121213/#comment49507>

    likewise.
    
    Also maybe only have one block that defines
    
    #if
    const char mangleStartIndicator[2] = " _";
    const char mangleEndIndicator[3] = " + ";
    #else
    ..
    #endif
    
    but first check on the need for a "different" end indicator.



kdecore/io/kdebug.cpp
<https://git.reviewboard.kde.org/r/121213/#comment49508>

    Why do you need to sharpen the match?


- Thomas Lübking


On Nov. 22, 2014, 11:02 nachm., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121213/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2014, 11:02 nachm.)
> 
> 
> Review request for KDE Software on Mac OS X and kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This patch adapts the parser in `maybeDemangledName` to the backtrace obtained in `kRealBacktrace` on OS X.
> 
> 
> Diffs
> -----
> 
>   kdecore/io/kdebug.cpp 872a05a 
> 
> Diff: https://git.reviewboard.kde.org/r/121213/diff/
> 
> 
> Testing
> -------
> 
> Works as expected on OS X 10.9.4 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141122/dd7a6d24/attachment-0001.html>