[KDE/Mac] Fixes for Filelight utility and LSkat game

[Ian Wadham]

Hi Nicolas, Bradley and Marko,

On 15/05/2014, at 2:43 PM, Ian Wadham wrote:
> On 14/05/2014, at 1:49 AM, Nicolas Pavillon wrote:
>>> I would like to retry the kdesrc-build route, but applying MacPorts patches to my local
>>> git repositories of KDE source and building and installing into non-MacPorts directories.
>>> 
>>> Does the above trac repository have all the patches I may need?  If so, where can I find the
>>> "post-configure hack" you mention above?  And indeed, what is a "post-configure hack”?
>> 
>> The fact that the repository is from a present installation also means that there may be 
>> patches that you will miss to install 4.13. 
>> 
>> Marko pointed out the place describing this post-configure hack. It means that you need
>> to configure kde4-runtime, then manually modify the file, and then build.
</snip>

> IMO, if MacPorts is having to patch the output from CMake (e.g. the link.txt file), it means
> that there is a problem in the CMakeLists.txt file or the KDE macros it uses.  So I have
> filed a bug report at https://bugs.kde.org/show_bug.cgi?id=334702 - I see there is a
> similar situation with building Konqueror in kde4-baseapps.  Maybe there are other
> cases.  So far I have had no response to the bug report.

This bug has been fixed in KDE's git repository, master branch and KDE/4.13 branch, which
means the fix will appear in KDE SC 4.13.2 and later releases of kdelibs: thanks to Raphael
Kubo da Costa, one of the KDE build-system experts.  The fix is available in patch format on
https://bugs.kde.org/show_bug.cgi?id=334702 as an attachment.  I have tried it out in my
kdesrc-build run.  Both kde-runtime (kglobalaccel target) and kde-baseapps (konqueror
target) compiled and linked correctly.

The patch should work in MacPorts and can replace the post-configure fixes in kde4-runtime
and kde4-baseapps Portfiles.  After applying the patch, please build kdelibs4 first.

Note that there was an error in the Apple OS X part of the kde4_add_kdeinit_executable()
CMake macro, which is used by quite a few KDE builds, see:
http://lxr.kde.org/search?_filestring=CMakeLists.txt&_string=kde4_add_kdeinit_executable&_casesensitive=1
So, with any luck, some other KDE build problems might go away.  The patch is something
to do with icons: maybe we will see improvements in that department.

All the best, Ian W.

P.S. I took a shortcut through bugs.kde.org. I had already been talking to Raphael and
Michael Pyne about a bug in KSharedDataCache on Mac OS X.  Investigating that is
one of my reasons for pursuing the kdesrc-build path.  The cache is used to speed up
loading and theme changes in a range of KDE apps.  So I wrote and asked Raphael
and Michael for help, via a message on that bug.  Raphael replied within a few hours.