[KDE/Mac] Review Request 121586: Restore upload functionality to git.reviewboard.kde.org

[Aleix Pol Gonzalez]

> On Dec. 22, 2014, 8:59 a.m., Kevin Funk wrote:
> > vcs/vcsdiff.cpp, line 204
> > <https://git.reviewboard.kde.org/r/121586/diff/4/?file=334874#file334874line204>
> >
> >     I suggest handling clear more generically:
> >     
> >     `clear() { *this = VcsDiff(); }`
> >     
> >     or remove the method altogether and use ` = VcsDiff()` instead of `.clear()` at the caller site.
> 
> Nicolai Hähnle wrote:
>     Sorry, I added an issue below at the same place when I meant to comment on this one. I believe "*d = VcsDiffPrivate();" would be preferable if the method stays.
> 
> Kevin Funk wrote:
>     Yep. You're right.
> 
> René J.V. Bertin wrote:
>     It seems VcsDiff.clear() isn't used anywhere, and the class itself isn't even in the public kdevplatform API, so I've preferred to remove the method.

Good call, removing is always best. :D


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121586/#review72409
-----------------------------------------------------------


On Dec. 30, 2014, 8:07 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121586/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2014, 8:07 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> A change was made on git.reviewboard.kde.org on December 13th a bit before 22h Europe/Paris time, ending support for p0 patch files. This broke the upload functionality in the current/stable version KDevelop's patchreview plugin.
> 
> The patch under review is a workaround (`*`) that restores this functionality by invoking the git helper process which generates the patchfiles with the correct arguments.
> 
> `*`) The real bug is in the reviewboard software, and should be addressed at that level. I work with a software distribution system that requires p0 patches, for which I created patches with KDevelop, something which will now require an additional step.
> 
> 
> Diffs
> -----
> 
>   plugins/git/gitplugin.h e930423 
>   plugins/git/gitplugin.cpp f38dc71 
>   plugins/patchreview/patchreview.cpp 18b63db 
>   plugins/reviewboard/reviewboardjobs.cpp 96cb354 
>   plugins/reviewboard/reviewboardplugin.cpp 1dd3bcb 
>   vcs/vcsdiff.h 573ec1b 
>   vcs/vcsdiff.cpp 01eb73c 
>   vcs/widgets/vcsdiffpatchsources.h 6a2f934 
>   vcs/widgets/vcsdiffpatchsources.cpp c3e2dae 
> 
> Diff: https://git.reviewboard.kde.org/r/121586/diff/
> 
> 
> Testing
> -------
> 
> Under OS X 10.9; this RR has been created from a patched copy of KDevelop 4.7 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141230/4467d87c/attachment.html>