[KDE/Mac] Review Request 121586: Restore upload functionality to git.reviewboard.kde.org

[René J.V. Bertin]

> On Dec. 22, 2014, 1:10 a.m., Aleix Pol Gonzalez wrote:
> > plugins/git/gitplugin.cpp, line 1073
> > <https://git.reviewboard.kde.org/r/121586/diff/4/?file=334869#file334869line1073>
> >
> >     Let's make them all with prefix, I can't think of a use-case we don't want the diffs without prefix.
> >     
> >     It will greatly simplify the implementation.

That's curious, I distinctly recall mentioning how useful those diffs without prefix were for me, and how I'd love to see an option in the GUI to obtain them. :)

Also and again, the review board uploader is conceived to work with a server read from a file in the project directory, not just with git.reviewboard.kde.org . How can we be sure that all those potential servers want diffs with prefixes?

I most likely won't be touching any code for about a week, that'll leave some time to come to a consensus, hopefully with feedback from some more people.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121586/#review72395
-----------------------------------------------------------


On Dec. 19, 2014, 6:41 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121586/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2014, 6:41 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> A change was made on git.reviewboard.kde.org on December 13th a bit before 22h Europe/Paris time, ending support for p0 patch files. This broke the upload functionality in the current/stable version KDevelop's patchreview plugin.
> 
> The patch under review is a workaround (`*`) that restores this functionality by invoking the git helper process which generates the patchfiles with the correct arguments.
> 
> `*`) The real bug is in the reviewboard software, and should be addressed at that level. I work with a software distribution system that requires p0 patches, for which I created patches with KDevelop, something which will now require an additional step.
> 
> 
> Diffs
> -----
> 
>   plugins/git/gitplugin.h e930423 
>   plugins/git/gitplugin.cpp f38dc71 
>   plugins/patchreview/patchreview.cpp 18b63db 
>   plugins/reviewboard/reviewboardjobs.cpp 96cb354 
>   plugins/reviewboard/reviewboardplugin.cpp 1dd3bcb 
>   vcs/vcsdiff.h 573ec1b 
>   vcs/vcsdiff.cpp 01eb73c 
>   vcs/widgets/vcsdiffpatchsources.h 6a2f934 
>   vcs/widgets/vcsdiffpatchsources.cpp c3e2dae 
> 
> Diff: https://git.reviewboard.kde.org/r/121586/diff/
> 
> 
> Testing
> -------
> 
> Under OS X 10.9; this RR has been created from a patched copy of KDevelop 4.7 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141222/056f9766/attachment-0001.html>