[KDE/Mac] Review Request 121586: Restore upload functionality to git.reviewboard.kde.org

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121586/#review72279
-----------------------------------------------------------



plugins/git/gitplugin.h
<https://git.reviewboard.kde.org/r/121586/#comment50410>

    remove the const and the default value.
    
    Also why adding a setter and a getter for something is never changed? Just make it always --no-prefix, that's fine.



plugins/reviewboard/reviewboardjobs.cpp
<https://git.reviewboard.kde.org/r/121586/#comment50411>

    toAscii -> toLatin1 are unrelated to the patch.
    
    Feel free to commit them right away though.



plugins/reviewboard/reviewboardjobs.cpp
<https://git.reviewboard.kde.org/r/121586/#comment50412>

    unrelated as well.


I'd also prefer to have the adoption of hte new property in reviewboard, so we know we are actually passing the correct data.

- Aleix Pol Gonzalez


On Dec. 18, 2014, 9:59 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121586/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2014, 9:59 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> A change was made on git.reviewboard.kde.org on December 13th a bit before 22h Europe/Paris time, ending support for p0 patch files. This broke the upload functionality in the current/stable version KDevelop's patchreview plugin.
> 
> The patch under review is a workaround (`*`) that restores this functionality by invoking the git helper process which generates the patchfiles with the correct arguments.
> 
> `*`) The real bug is in the reviewboard software, and should be addressed at that level. I work with a software distribution system that requires p0 patches, for which I created patches with KDevelop, something which will now require an additional step.
> 
> 
> Diffs
> -----
> 
>   plugins/reviewboard/reviewboardjobs.cpp 007a6e0 
>   plugins/reviewboard/reviewboardplugin.cpp 1dd3bcb 
>   vcs/vcsdiff.h 573ec1b 
>   vcs/vcsdiff.cpp 01eb73c 
>   vcs/widgets/vcsdiffpatchsources.h 6a2f934 
>   vcs/widgets/vcsdiffpatchsources.cpp c3e2dae 
>   plugins/git/gitplugin.h e930423 
>   plugins/git/gitplugin.cpp f38dc71 
>   plugins/patchreview/patchreview.cpp 18b63db 
> 
> Diff: https://git.reviewboard.kde.org/r/121586/diff/
> 
> 
> Testing
> -------
> 
> Under OS X 10.9; this RR has been created from a patched copy of KDevelop 4.7 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141219/70ee3163/attachment-0001.html>