[KDE/Mac] Review Request 121586: Restore upload functionality to git.reviewboard.kde.org

René J.V. Bertin rjvbertin at gmail.com
Thu Dec 18 20:26:40 UTC 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 18, 2014, 9:26 p.m.)

Review request for KDE Software on Mac OS X and KDevelop.


This new version of the patch restores the correct hunk count and highlighting. It does that by passing the appropriate parameters to libkomparediff2

I have added a switch to the gitplugin to let it make p1 or p0 patches; currently the default (p1) is used.

Repository: kdevplatform


A change was made on git.reviewboard.kde.org on December 13th a bit before 22h Europe/Paris time, ending support for p0 patch files. This broke the upload functionality in the current/stable version KDevelop's patchreview plugin.

The patch under review is a workaround (`*`) that restores this functionality by invoking the git helper process which generates the patchfiles with the correct arguments.

`*`) The real bug is in the reviewboard software, and should be addressed at that level. I work with a software distribution system that requires p0 patches, for which I created patches with KDevelop, something which will now require an additional step.

Diffs (updated)

  plugins/git/gitplugin.h e930423 
  plugins/git/gitplugin.cpp f38dc71 
  plugins/patchreview/patchreview.cpp 18b63db 
  plugins/reviewboard/reviewboardjobs.cpp 007a6e0 
  plugins/reviewboard/reviewboardplugin.cpp 1dd3bcb 
  vcs/vcsdiff.h 573ec1b 
  vcs/vcsdiff.cpp 01eb73c 
  vcs/widgets/vcsdiffpatchsources.h 6a2f934 
  vcs/widgets/vcsdiffpatchsources.cpp c3e2dae 

Diff: https://git.reviewboard.kde.org/r/121586/diff/


Under OS X 10.9; this RR has been created from a patched copy of KDevelop 4.7 .


René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141218/c8fe1b0c/attachment.html>

More information about the kde-mac mailing list