[KDE/Mac] Review Request 121586: Restore upload functionality to git.reviewboard.kde.org

[René J.V. Bertin]

> On Dec. 17, 2014, 11:30 p.m., Jeremy Whiting wrote:
> > Does this happen to still work on older reviewboard installations? If so I say go for it.
> 
> René J.V. Bertin wrote:
>     Erm, I've only tested this with KDE's reviewboard, which is the only one I use.
>     
>     However, KDevelop 4.90.90 (the KF5 version) creates p1 patches too, which is how I figured out why my uploads were failing ...

One thing I did notice, first in KDevelop KF5, and now in my patched 4.7 version: the changed hunk count is always 0. I'm pretty sure that wasn't the case before. And that would suggest that this regression was introduced the same way in KDevelop KF5, and will disappear when the review plugin is changed to know how to handle p1 patchfiles.

In the meantime, and also inspired by Jeremy's remark, I'd really like to vote for an additional button/checkbox in the patchreview UI, allowing to select a p1 diff.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121586/#review72213
-----------------------------------------------------------


On Dec. 17, 2014, 11:25 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121586/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 11:25 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> A change was made on git.reviewboard.kde.org on December 13th a bit before 22h Europe/Paris time, ending support for p0 patch files. This broke the upload functionality in the current/stable version KDevelop's patchreview plugin.
> 
> The patch under review is a workaround (`*`) that restores this functionality by invoking the git helper process which generates the patchfiles with the correct arguments.
> 
> `*`) The real bug is in the reviewboard software, and should be addressed at that level. I work with a software distribution system that requires p0 patches, for which I created patches with KDevelop, something which will now require an additional step.
> 
> 
> Diffs
> -----
> 
>   plugins/git/gitplugin.cpp f38dc71 
> 
> Diff: https://git.reviewboard.kde.org/r/121586/diff/
> 
> 
> Testing
> -------
> 
> Under OS X 10.9; this RR has been created from a patched copy of KDevelop 4.7 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141217/7191ae5f/attachment.html>