[KDE/Mac] Review Request 121586: Restore upload functionality to git.reviewboard.kde.org

René J.V. Bertin rjvbertin at gmail.com
Wed Dec 17 22:25:26 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121586/
-----------------------------------------------------------

Review request for KDE Software on Mac OS X and KDevelop.


Repository: kdevplatform


Description
-------

A change was made on git.reviewboard.kde.org on December 13th a bit before 22h Europe/Paris time, ending support for p0 patch files. This broke the upload functionality in the current/stable version KDevelop's patchreview plugin.

The patch under review is a workaround (`*`) that restores this functionality by invoking the git helper process which generates the patchfiles with the correct arguments.

`*`) The real bug is in the reviewboard software, and should be addressed at that level. I work with a software distribution system that requires p0 patches, for which I created patches with KDevelop, something which will now require an additional step.


Diffs
-----

  plugins/git/gitplugin.cpp f38dc71 

Diff: https://git.reviewboard.kde.org/r/121586/diff/


Testing
-------

Under OS X 10.9; this RR has been created from a patched copy of KDevelop 4.7 .


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141217/c0a1abca/attachment.html>


More information about the kde-mac mailing list