[KDE/Mac] Review Request 121394: [OS X] create a dedicated Info.plist for kdevelop

[René J.V. Bertin]

On Dec. 8, 2014, 11:24 p.m., René J.V. Bertin wrote:
> > Some other notes for a follow-up patch (feel free to commit directly):
> > - Please use `if (APPLE)` instead. I'm surprised `Q_WS_MAC` is set as *CMake* variable...
> > - Fix indenting above your hunk
> 
> René J.V. Bertin wrote:
>     I was surprised too about Q_WS_MAC, but the code template comes from kdelibs, ultimately. The Info.plist.template name too, so I'm not sure what you mean with "consistent with the original file"?
> 
> Kevin Funk wrote:
>     Isn't this forked from `/usr/share/cmake/Modules/MacOSXBundleInfo.plist.in`?
>     
>     And please use 'APPLE', Q_WS_MAC is no longer defined in Qt5.

No, at least not by me. As I said, I got the Info.plist template from kdelibs (and kdevelop is not the first project where I'm using it under that name).


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121394/#review71594
-----------------------------------------------------------


On Dec. 8, 2014, 11:24 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121394/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 11:24 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDevelop and Alexander Dymo.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This patch provides an Info.plist template and a change to the kdevelop/app/CMakeLists.txt to generate an appropriate info dictionary for the kdevelop app bundle.
> 
> The main interest at this point is the deactivation of "app nap" which will suspend the whole IDE if it remains (active) in the background for too long.
> The same file can also be used to define the application icon, and document types the application can handle. I intend to address those features in future updates (the latter will require changes to the code, though).
> 
> 
> Diffs
> -----
> 
>   app/CMakeLists.txt d84253d 
>   app/Info.plist.template PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121394/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.4 . App Nap disabling seems to work as expected (and described in user feedback on the feature and its per-application deactivation). 
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141209/ecb81e11/attachment.html>