[KDE/Mac] Review Request 121213: demangling symbols in the backtrace on OS X and FreeBSD/PC-BSD

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121213/
-----------------------------------------------------------

(Updated Dec. 2, 2014, 6:02 p.m.)


Review request for KDE Software on Mac OS X and kdelibs.


Changes
-------

I've given this patch a bit more love, and since we were discussing the format of the backtrace returned on different platforms, I adapted the demangler/parser to function on OpenIndiana (Solaris) and PC-BSD (FreeBSD) as well.

I also added a test method to TestClass1 in kdebugtest.cpp as well as a standalone test (a newer version of the backtrace.c programme attached to this RR).


Summary (updated)
-----------------

demangling symbols in the backtrace on OS X and FreeBSD/PC-BSD


Repository: kdelibs


Description (updated)
-------

This patch adapts the parser in `maybeDemangledName` to the backtrace obtained in `kRealBacktrace` on OS X, Solaris (OpenIndiana) and PC-BSD/FreeBSD.
It also unlocks access to the functionality on FreeBSD/PC-BSD.


Diffs (updated)
-----

  kdecore/CMakeLists.txt 082e252 
  kdecore/io/kdebug.cpp 872a05a 
  kdecore/tests/CMakeLists.txt c30c76e 
  kdecore/tests/backtracetest.cpp PRE-CREATION 
  kdecore/tests/kdebugtest.cpp 21efbc0 

Diff: https://git.reviewboard.kde.org/r/121213/diff/


Testing (updated)
-------

Works as expected on OS X 10.9.4 and PC-BSD/FreeBSD 10.


File Attachments
----------------

minimal test for backtrace functionality and parsing; can be built as C and C++
  https://git.reviewboard.kde.org/media/uploaded/files/2014/11/25/e9d48fea-2506-493c-b068-26a8e7d12b6c__backtrace.c


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141202/fc2906e7/attachment.html>