[KDE/Mac] Review Request 119900: [OS X] less obtrusive missing declaration widget

[RJVB Bertin]

> On Aug. 26, 2014, 4:17 p.m., Kevin Funk wrote:
> > This can be discared now, right?

Yes...


- RJVB


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119900/#review65278
-----------------------------------------------------------


On Aug. 22, 2014, 2:06 p.m., RJVB Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119900/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2014, 2:06 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This patch renders the assistant popup widget used for suggesting to add missing declarations to a class being edited less obtrusive on configurations like OS X where the Alt modifier might be used in shortcuts like Word-Left/Right (to match them with the system default).
> 
> The patch basically makes the Alt keypress to handle the popup's programmatic shortcuts a transient trigger rather than a state change that persists until the popup is either accepted or dismissed. This will of course apply to other widgets than just the one presented by the missing declaration feature.
> 
> For more details, see https://bugs.kde.org/show_bug.cgi?id=338380
> 
> 
> Diffs
> -----
> 
>   shell/assistantpopup.cpp 06d6ccf 
> 
> Diff: https://git.reviewboard.kde.org/r/119900/diff/
> 
> 
> Testing
> -------
> 
> With KDevelop 4.7RC (x.7.60) on OS X (10.6.8, KDE 4.12.5 and Qt 4.8.6 from MacPorts) and with KDevelop git/master on Linux (Ubuntu 14.04 with KDE 4.13.3 and Qt 4.8.6) with word left/right evoked by Alt+Left/Right).
> 
> 
> Thanks,
> 
> RJVB Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20140826/d26076c4/attachment-0001.html>