[KDE/Mac] Mac Build fixed for kdebase/workspace trunk

[Benjamin Reed]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 6/2/09 11:53 AM, Andreas Stricker wrote:
> Hi
> 
> As noted before I tried to build kdebase/workspace on Mac OSX.
> The main reason was to get access to the plasma engines,
> applets, containments, wallpapers, and data engines here.
> 
> This only fixes build error's. There are still a lot of issues
> at runtime. But as the gap to a buildable system is not to big
> this helps to get keep the code buildable.
> 
> I tried to differentiate between parts not available on
> Mac ( checking with "NOT APPLE" in cmake or "!defined(Q_OS_MAC)"
> in Code) and parts not available on non-X11 system (check for
> Q_WS_X11).


I just started looking through this and one thing I'm noticing is that
you did end up mixing up some APPLE-specific things with X11-specific
things.

For example, patch 1 does:

- -if(NOT WIN32)
+if(NOT WIN32 AND NOT APPLE)
   macro_optional_add_subdirectory( kcheckpass )
   macro_optional_add_subdirectory( kscreensaver )
   macro_optional_add_subdirectory( kwin )

...this should really be:

if(Q_WS_X11)

...since all of those things would be valid X11 applications if building
against Qt4/X11 on Mac OS X (which the Fink KDE4 packages allow, in a
variant).

There are a lot of similar occurrences further down.

Other than that, this looks really good.  I'll take a look at adapting
those to the X11-based checks instead and give it a shot.

- -- 
Benjamin Reed a.k.a. Ranger Rick
Fink, KDE, and Mac OS X development

Blog: http://www.raccoonfink.com/
Music: http://music.raccoonfink.com/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iD8DBQFKJV02Uu+jZtP2Zf4RApb5AJ0d/+IDFOn2A/Ftx05XRR1Gk+6q+QCeJqKI
l+ioO7FISPars9GsRCAMSyk=
=Fm6d
-----END PGP SIGNATURE-----