[Kamoso] Review Request 118979: Porting to GStreamer-1.0 API and QtGStreamer-1.2

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118979/
-----------------------------------------------------------

(Updated June 28, 2014, 8:30 p.m.)


Review request for Kamoso, Àlex Fiestas, Aleix Pol Gonzalez, Diane Trout, and George Kiagiadakis.


Changes
-------

Updated the patch with Diane's comments. Only point I excluded for now: I do not set GST_VIDEO_CAPS_MAKE("RGB"), since in the video-pipeline format=RGB is set explicitely. If GST_VIDEO_CAPS_MAKE is the nicer way (or if I am missing something and both do different things), I will happily apply this though.

If I see it right, we then reduced the number of concurrent porting patchs from 3 to 2 (this patch and the camerabin patch).


Repository: kamoso


Description
-------

This is the first iteration of a porting patch to upgrade Kamoso to work with GStreamer-1.x (in particular, 0.10 is deprecated and unmaintained by upstream). The patch in its current version does the following:
* update the cmake find module to find the new version of gstreamer and qtgstreamer
* fixes compilation with the new version
I am quite sure that further changes at the pipelines are necessary to make it work at runtime, yet an area where I do not have much experience (hence, all these people you get the review request :)

In the big picture, I would like to have Kamoso ported asap, since with Artikulate a first KDE application switched to the new QtGStreamer version and the continiuous integration system can only support one qtgstreamer version for all. Also, it would be good to have all KDE applications ready for QtGStreamer-1.2 with the KDE SC 4.14 release to allow distros to upgrade all in one step.


Diffs (updated)
-----

  CMakeLists.txt 5d6bfb1 
  cmake/FindGStreamer.cmake a1b6e33 
  src/webcamwidget.cpp 62b7831 

Diff: https://git.reviewboard.kde.org/r/118979/diff/


Testing
-------

Compiles, but no runtime testing done.


Thanks,

Andreas Cord-Landwehr

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-kamoso/attachments/20140628/dc34e9d8/attachment.html>