[Kamoso] Review Request 112751: Improve handling of multiple/no webcams

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112751/#review40102
-----------------------------------------------------------

Ship it!


Besides those coding styles issues, ship it! good job.


src/kamoso.cpp
<http://git.reviewboard.kde.org/r/112751/#comment29672>

    space between() > 1



src/kamoso.cpp
<http://git.reviewboard.kde.org/r/112751/#comment29673>

    Space before/after operator


- Àlex Fiestas


On Sept. 15, 2013, 9:10 p.m., Michael Georg Hansen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112751/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2013, 9:10 p.m.)
> 
> 
> Review request for Kamoso.
> 
> 
> Description
> -------
> 
> This patch improves the handling of multiple webcams and the case of no webcam:
> 
> - If no webcam is found, display a message that no webcam was found.
> - Fix visibility of webcam chooser combo box if two webcams are plugged in.
> - Handle removal of webcams, automatically switch to another webcam. Previously, if you had two webcams and unplugged the current webcam, you could not switch to the other one because the chooser combo was hidden.
> 
> 
> Diffs
> -----
> 
>   src/kamoso.h dcd8987609698068b46902ed61812ef6b4fa5f96 
>   src/kamoso.cpp 4ca0dc4fe43a912b9a448d3e19af07e63a7935a3 
>   src/mainWidget.ui f2a4f281f6178ad0c514f0d70a4be1d1f0ac3977 
> 
> Diff: http://git.reviewboard.kde.org/r/112751/diff/
> 
> 
> Testing
> -------
> 
> - Start kamoso with 0 - 3 webcams (v4l's vivi module is a good helper here to create a dummy webcam. Just "modprobe vivi".).
> - Plug webcams in and out while kamoso runs.
> - Not tested: Unplugging of webcams while video is recorded, since that does not work on my system.
> 
> 
> Thanks,
> 
> Michael Georg Hansen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-kamoso/attachments/20130916/903db9f6/attachment.html>