Review Request 128653: kxmlexport: Use QTEST_GUILESS_MAIN, don't link to Qt5::Gui

[Heiko Becker]

> On Sept. 21, 2016, 5:30 nachm., Heiko Becker wrote:
> > Ping?
> 
> Gilles Caulier wrote:
>     I never receive a notification about this entry at creation in board...
> 
> Gilles Caulier wrote:
>     The patch is fine to commit

No problem, thanks for the review.


- Heiko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128653/#review99373
-----------------------------------------------------------


On Sept. 21, 2016, 6:39 nachm., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128653/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2016, 6:39 nachm.)
> 
> 
> Review request for Kipi-plugins and Gilles Caulier.
> 
> 
> Repository: kipi-plugins
> 
> 
> Description
> -------
> 
> Both is not necessary for the test to run successfully and it allows
> testing without a running X server.
> 
> 
> Diffs
> -----
> 
>   kmlexport/tests/CMakeLists.txt a33255f9ae7d0650595ce899866bb60194057165 
>   kmlexport/tests/test_kmlexport_gpxparsing.cpp 4afa1a51bcb4003aa01e6b0328c752f1029fd049 
> 
> Diff: https://git.reviewboard.kde.org/r/128653/diff/
> 
> 
> Testing
> -------
> 
> cmake .. && make && make test
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-imaging/attachments/20160921/cc81d2cf/attachment.html>