[Kde-imaging] KIPI imgur plugin

Fri Jun 24 13:12:20 UTC 2016

Fabian,

Can you prepare the inclusion of OAuth2 source code in
common/libkipiplugins/oauth2 directory for later 5.0.0 release date ?

Thanks in advance

Gilles Caulier

2016-06-22 15:30 GMT+02:00 Gilles Caulier <caulier.gilles at gmail.com>:

> Right i see.
>
> As it's explained in README.md, we must have a copy in libkipi-plugins as
> 3rdparty lib.
>
> It's not a problem. We will see this after 5.0.0 final release
>
> Gilles Caulier
>
> 2016-06-22 15:24 GMT+02:00 Fabian Vogt <fabian at ritter-vogt.de>:
>
>> I am, too.
>> Relying on that library through CMake will cause severe
>> source and especially package maintenance headaches.
>>
>>
>> Am Mittwoch, 22. Juni 2016, 15:20:50 CEST schrieb Gilles Caulier:
>> > I talking about this one : https://github.com/pipacs/o2
>> >
>> > Gilles Caulier
>> >
>> > 2016-06-22 15:14 GMT+02:00 Fabian Vogt <fabian at ritter-vogt.de>:
>> >
>> > > Am Mittwoch, 22. Juni 2016, 14:45:43 CEST schrieb Gilles Caulier:
>> > > > No. We don't use a git submodule.
>> > > >
>> > > > We must implement/found a cmake script which will search OAuth2
>> library
>> > > on
>> > > > the system and compile and link with it in each plugins, through
>> cmake.
>> > >
>> > > Ok, but it looks like that library (which isn't actually one)
>> > > isn't meant to be used like that. They don't even use the pimpl idiom,
>> > > so it's not even possible to make a package manually...
>> > >
>> > > Cheers,
>> > > Fabian
>> > >
>> > > >
>> > > > Gilles Caulier
>> > > >
>> > > > 2016-06-20 19:05 GMT+02:00 Fabian Vogt <fabian at ritter-vogt.de>:
>> > > >
>> > > > > I meant a git submodule, for easier updating.
>> > > > >
>> > > > > Cheers,
>> > > > > Fabian
>> > > > >
>> > > > > Am Montag, 20. Juni 2016, 18:58:27 CEST schrieb Gilles Caulier:
>> > > > > > 2016-06-20 18:53 GMT+02:00 Fabian Vogt <fabian at ritter-vogt.de>:
>> > > > > >
>> > > > > > > In that case it shouldn't be a massive issue to include the
>> full
>> > > repo
>> > > > > > > as submodule then. There may be the occasional breakage on
>> updates,
>> > > > > > > though.
>> > > > > > >
>> > > > > >
>> > > > > > The sub module of what ? OAuth library ?
>> > > > > >
>> > > > > > No the link to this library will be done through an external
>> > > dependency.
>> > > > > > It's easy to deal with CMake
>> > > > > >
>> > > > > > Gilles Caulier
>> > > > > >
>> > > > > >
>> > > > > > >
>> > > > > > > Cheers,
>> > > > > > > Fabian
>> > > > > > >
>> > > > > > > Am Montag, 20. Juni 2016, 17:32:39 CEST schrieb Gilles
>> Caulier:
>> > > > > > > > All plugins will be rebuild in fact at packaging time,
>> excepted
>> > > for
>> > > > > > > > debuging of course
>> > > > > > > > Gilles Caulier
>> > > > > > > >
>> > > > > > > > 2016-06-20 17:27 GMT+02:00 Fabian Vogt <
>> fabian at ritter-vogt.de>:
>> > > > > > > >
>> > > > > > > > > Personally, I don't. Generally, that's a good question.
>> > > > > > > > > As the "library" itself is not really a library
>> > > > > > > > > (no version numbers, thus not ABI nor API stable),
>> > > > > > > > > it might be worth to have an abstraction layer to make it
>> so.
>> > > > > > > > > Is it important for libkipiplugins to be ABI/API stable
>> > > > > > > > > or can it be relied on that all plugins will always be
>> rebuilt?
>> > > > > > > > >
>> > > > > > > > > Am Montag, 20. Juni 2016, 17:05:30 CEST schrieb Gilles
>> Caulier:
>> > > > > > > > > > yes we can depend kipi-plugins to use OAuth2 as main
>> > > dependency.
>> > > > > > > > > >
>> > > > > > > > > > If we do it, do you think that you need a common and
>> > > customized
>> > > > > > > interface
>> > > > > > > > > > for this library in libkipiplugins ?
>> > > > > > > > > >
>> > > > > > > > > > Gilles Caulier
>> > > > > > > > > >
>> > > > > > > > > > 2016-06-20 15:55 GMT+02:00 Fabian Vogt <
>> > > fabian at ritter-vogt.de>:
>> > > > > > > > > >
>> > > > > > > > > > > I didn't do that for various reasons:
>> > > > > > > > > > >
>> > > > > > > > > > > - Simplicity: A lot of additional files for just one
>> > > plugin.
>> > > > > > > > > > >     Now that more plugins are going to be adapted
>> that's
>> > > less
>> > > > > the
>> > > > > > > case.
>> > > > > > > > > > > - Maintainability: It does not come as a system-wide
>> > > library
>> > > > > and
>> > > > > > > > > > > incorporating
>> > > > > > > > > > >     other project's source codes is always a PITA
>> > > > > > > > > > > - Licensing: I'm not an expert, I don't even recognize
>> > > what it
>> > > > > is
>> > > > > > > > > licensed
>> > > > > > > > > > > under.
>> > > > > > > > > > >
>> > > > > > > > > > > If libkipiplugins would now integrate it, I'd change
>> the
>> > > imgur
>> > > > > > > plugin
>> > > > > > > > > to
>> > > > > > > > > > > use it,
>> > > > > > > > > > > of course.
>> > > > > > > > > > >
>> > > > > > > > > > > Am Montag, 20. Juni 2016, 15:41:00 CEST schrieb Gilles
>> > > Caulier:
>> > > > > > > > > > > > And why not to use OAuth2 library as well. It's well
>> > > > > maintained
>> > > > > > > and
>> > > > > > > > > > > already
>> > > > > > > > > > > > support flickr, google, facebook, etc... The
>> advantage
>> > > is to
>> > > > > not
>> > > > > > > > > rewrite
>> > > > > > > > > > > > existing code, factoring and delegate the Oauth
>> handling
>> > > to
>> > > > > the
>> > > > > > > > > library
>> > > > > > > > > > > >
>> > > > > > > > > > > > Gilles Caulier
>> > > > > > > > > > > >
>> > > > > > > > > > > > 2016-06-20 15:36 GMT+02:00 Fabian Vogt <
>> > > > > fabian at ritter-vogt.de>:
>> > > > > > > > > > > >
>> > > > > > > > > > > > > A: I wrote a small implementation of OAuth 2 from
>> > > scratch:
>> > > > > > > > > > > > >
>> > > > > > > > > > > > >
>> > > > > > > > > > >
>> > > > > > > > >
>> > > > > > >
>> > > > >
>> > >
>> https://github.com/Vogtinator/kipi-plugins/blob/imgurrewrite/imgur/koauth2.cpp
>> > > > > > > > > > > > > Compared to OAuth 1, OAuth 2 is really simple to
>> > > handle.
>> > > > > > > > > > > > >
>> > > > > > > > > > > > > Am Montag, 20. Juni 2016, 15:26:26 CEST schrieb
>> Gilles
>> > > > > Caulier:
>> > > > > > > > > > > > > > Q : do you use OAuth2 library API in your code :
>> > > > > > > > > > > > > >
>> > > > > > > > > > > > > > http://oauth.net/2/
>> > > > > > > > > > > > > >
>> > > > > > > > > > > > > > Gilles Caulier
>> > > > > > > > > > > > > >
>> > > > > > > > > > > > > > 2016-06-19 22:58 GMT+02:00 Gilles Caulier <
>> > > > > > > > > caulier.gilles at gmail.com
>> > > > > > > > > > > >:
>> > > > > > > > > > > > > >
>> > > > > > > > > > > > > > > Look in kipi-plugins/common/libkipiplugins/
>> we have
>> > > > > shared
>> > > > > > > > > > > > > impementation
>> > > > > > > > > > > > > > > used by all kipi tools.
>> > > > > > > > > > > > > > >
>> > > > > > > > > > > > > > > Gilles Caulier
>> > > > > > > > > > > > > > >
>> > > > > > > > > > > > > > > 2016-06-19 22:35 GMT+02:00 Fabian Vogt <
>> > > > > > > fabian at ritter-vogt.de
>> > > > > > > > > >:
>> > > > > > > > > > > > > > >
>> > > > > > > > > > > > > > >> Am Sonntag, 19. Juni 2016, 21:58:57 CEST
>> schrieben
>> > > > > Sie:
>> > > > > > > > > > > > > > >> > Thanks Fabian. We will take a look.
>> > > > > > > > > > > > > > >> >
>> > > > > > > > > > > > > > >> > It's a little bit short to include this
>> code in
>> > > next
>> > > > > > > 5.0.0
>> > > > > > > > > as it
>> > > > > > > > > > > > > will be
>> > > > > > > > > > > > > > >> > released in 2 weeks, but with next 5.1.0
>> > > certainly.
>> > > > > > > > > > > > > > >>
>> > > > > > > > > > > > > > >> Yeah, the code needs some more work anyway.
>> > > > > > > > > > > > > > >>
>> > > > > > > > > > > > > > >> > What do you think about to generalize OAuth
>> > > library
>> > > > > use
>> > > > > > > in
>> > > > > > > > > > > others
>> > > > > > > > > > > > > kipi
>> > > > > > > > > > > > > > >> > tools (facebook, google, flickr, etc...) ?
>> > > > > > > > > > > > > > >>
>> > > > > > > > > > > > > > >> It's a good idea to share the code, but I'm
>> not
>> > > quite
>> > > > > sure
>> > > > > > > > > where
>> > > > > > > > > > > it
>> > > > > > > > > > > > > > >> should be put. Neither the plugins nor kipi
>> > > itself are
>> > > > > > > quite
>> > > > > > > > > the
>> > > > > > > > > > > right
>> > > > > > > > > > > > > > >> place.
>> > > > > > > > > > > > > > >>
>> > > > > > > > > > > > > > >> >
>> > > > > > > > > > > > > > >> > Gilles Caulier
>> > > > > > > > > > > > > > >> >
>> > > > > > > > > > > > > > >> > 2016-06-19 21:12 GMT+02:00 Fabian Vogt <
>> > > > > > > > > fabian at ritter-vogt.de>:
>> > > > > > > > > > > > > > >> >
>> > > > > > > > > > > > > > >> > > Hi,
>> > > > > > > > > > > > > > >> > >
>> > > > > > > > > > > > > > >> > > I did. I'm now waiting for a response
>> from
>> > > Maik.
>> > > > > > > > > > > > > > >> > >
>> > > > > > > > > > > > > > >> > > I pushed the code I've currently got on
>> > > GitHub,
>> > > > > > > > > > > > > > >> > > if someone wants to have a look:
>> > > > > > > > > > > > > > >> > >
>> > > > > > > > >
>> https://github.com/Vogtinator/kipi-plugins/tree/imgurrewrite
>> > > > > > > > > > > > > > >> > >
>> > > > > > > > > > > > > > >> > > Cheers,
>> > > > > > > > > > > > > > >> > > Fabian
>> > > > > > > > > > > > > > >> > >
>> > > > > > > > > > > > > > >> > > Am Sonntag, 19. Juni 2016, 20:06:49 CEST
>> > > schrieb
>> > > > > > > Gilles
>> > > > > > > > > > > Caulier:
>> > > > > > > > > > > > > > >> > > > Fabian,
>> > > > > > > > > > > > > > >> > > >
>> > > > > > > > > > > > > > >> > > > Did you seen me previous message ?
>> > > > > > > > > > > > > > >> > > >
>> > > > > > > > > > > > > > >> > > > Gilles Caulier
>> > > > > > > > > > > > > > >> > > >
>> > > > > > > > > > > > > > >> > > > 2016-06-11 13:49 GMT+02:00 Gilles
>> Caulier <
>> > > > > > > > > > > > > caulier.gilles at gmail.com
>> > > > > > > > > > > > > > >> >:
>> > > > > > > > > > > > > > >> > > >
>> > > > > > > > > > > > > > >> > > > > Hi,
>> > > > > > > > > > > > > > >> > > > >
>> > > > > > > > > > > > > > >> > > > > Maik Qualmann <metzpinguin at gmail.com
>> >
>> > > work on
>> > > > > > > this
>> > > > > > > > > task
>> > > > > > > > > > > > > > >> currently.
>> > > > > > > > > > > > > > >> > > You is
>> > > > > > > > > > > > > > >> > > > > wecome to help him of course.
>> > > > > > > > > > > > > > >> > > > >
>> > > > > > > > > > > > > > >> > > > > We have talking about to use OAuth2
>> as
>> > > well
>> > > > > > > > > everywhere in
>> > > > > > > > > > > > > > >> kipi-plugins,
>> > > > > > > > > > > > > > >> > > > > not only for ImgUr tool. Flickr,
>> Facebook,
>> > > > > Google,
>> > > > > > > > > etc,
>> > > > > > > > > > > need a
>> > > > > > > > > > > > > > >> > > simplified
>> > > > > > > > > > > > > > >> > > > > way to authentificate user on web
>> service.
>> > > > > OAuth2
>> > > > > > > is
>> > > > > > > > > the
>> > > > > > > > > > > best
>> > > > > > > > > > > > > way
>> > > > > > > > > > > > > > >> to
>> > > > > > > > > > > > > > >> > > go.
>> > > > > > > > > > > > > > >> > > > >
>> > > > > > > > > > > > > > >> > > > > The goal also of Maik work is to
>> drop KIO
>> > > > > slaves
>> > > > > > > every
>> > > > > > > > > > > where
>> > > > > > > > > > > > > in
>> > > > > > > > > > > > > > >> > > > > kipi-plugins and to use native Qt5
>> API
>> > > > > instead.
>> > > > > > > KIO is
>> > > > > > > > > > > just a
>> > > > > > > > > > > > > pain
>> > > > > > > > > > > > > > >> > > under
>> > > > > > > > > > > > > > >> > > > > non Linux OS and we don't have any
>> free
>> > > time
>> > > > > to
>> > > > > > > > > > > investiguate
>> > > > > > > > > > > > > > >> about.
>> > > > > > > > > > > > > > >> > > > > digiKam+kipi-plugins must work as
>> well
>> > > under
>> > > > > OSX
>> > > > > > > and
>> > > > > > > > > > > Windows.
>> > > > > > > > > > > > > > >> > > > >
>> > > > > > > > > > > > > > >> > > > > I you is interested to help Maik,
>> you is
>> > > > > welcome.
>> > > > > > > I CC
>> > > > > > > > > > > him to
>> > > > > > > > > > > > > this
>> > > > > > > > > > > > > > >> > > mail...
>> > > > > > > > > > > > > > >> > > > >
>> > > > > > > > > > > > > > >> > > > > Best
>> > > > > > > > > > > > > > >> > > > >
>> > > > > > > > > > > > > > >> > > > > Gilles Caulier
>> > > > > > > > > > > > > > >> > > > >
>> > > > > > > > > > > > > > >> > > > > 2016-06-10 13:54 GMT+02:00 Fabian
>> Vogt <
>> > > > > > > > > > > fabian at ritter-vogt.de
>> > > > > > > > > > > > > >:
>> > > > > > > > > > > > > > >> > > > >
>> > > > > > > > > > > > > > >> > > > >> Hi,
>> > > > > > > > > > > > > > >> > > > >>
>> > > > > > > > > > > > > > >> > > > >> I started an attempt to fix the
>> imgur
>> > > plugin
>> > > > > for
>> > > > > > > both
>> > > > > > > > > > > > > anonymous
>> > > > > > > > > > > > > > >> and
>> > > > > > > > > > > > > > >> > > > >> authorized uploads
>> > > > > > > > > > > > > > >> > > > >> a few days ago, but today I noticed
>> that
>> > > the
>> > > > > > > plugin
>> > > > > > > > > got
>> > > > > > > > > > > > > support
>> > > > > > > > > > > > > > >> for
>> > > > > > > > > > > > > > >> > > API3
>> > > > > > > > > > > > > > >> > > > >> recently.
>> > > > > > > > > > > > > > >> > > > >>
>> > > > > > > > > > > > > > >> > > > >> My fix is basically a complete
>> rewrite
>> > > (just
>> > > > > kept
>> > > > > > > > > small
>> > > > > > > > > > > > > parts),
>> > > > > > > > > > > > > > >> not
>> > > > > > > > > > > > > > >> > > > >> anywhere near complete,
>> > > > > > > > > > > > > > >> > > > >> so I wonder whether I should
>> continue
>> > > > > working on
>> > > > > > > it.
>> > > > > > > > > > > > > > >> > > > >> Would a complete rewrite with full
>> > > support
>> > > > > for
>> > > > > > > > > OAuth2 be
>> > > > > > > > > > > > > welcome?
>> > > > > > > > > > > > > > >> > > > >>
>> > > > > > > > > > > > > > >> > > > >> BTW: I haven't found a guide for
>> KIPI
>> > > > > > > contributions,
>> > > > > > > > > > > does it
>> > > > > > > > > > > > > work
>> > > > > > > > > > > > > > >> > > mostly
>> > > > > > > > > > > > > > >> > > > >> over
>> > > > > > > > > > > > > > >> > > > >> this ML, the reviewboard or
>> phabricator?
>> > > > > > > > > > > > > > >> > > > >>
>> > > > > > > > > > > > > > >> > > > >> Cheers,
>> > > > > > > > > > > > > > >> > > > >> Fabian
>> > > > > > > > > > > > >
>> > > > > > > > > > > > > _______________________________________________
>> > > > > > > > > > > > > Kde-imaging mailing list
>> > > > > > > > > > > > > Kde-imaging at kde.org
>> > > > > > > > > > > > > https://mail.kde.org/mailman/listinfo/kde-imaging
>> > > > > > > > > > > > >
>> > > > > > > > > > > >
>> > > > > > > > > > >
>> > > > > > > > > > >
>> > > > > > > > > > > _______________________________________________
>> > > > > > > > > > > Kde-imaging mailing list
>> > > > > > > > > > > Kde-imaging at kde.org
>> > > > > > > > > > > https://mail.kde.org/mailman/listinfo/kde-imaging
>> > > > > > > > > > >
>> > > > > > > > > >
>> > > > > > > > >
>> > > > > > > > >
>> > > > > > > > > _______________________________________________
>> > > > > > > > > Kde-imaging mailing list
>> > > > > > > > > Kde-imaging at kde.org
>> > > > > > > > > https://mail.kde.org/mailman/listinfo/kde-imaging
>> > > > > > > > >
>> > > > > > > >
>> > > > > > >
>> > > > > > >
>> > > > > > > _______________________________________________
>> > > > > > > Kde-imaging mailing list
>> > > > > > > Kde-imaging at kde.org
>> > > > > > > https://mail.kde.org/mailman/listinfo/kde-imaging
>> > > > > > >
>> > > > > >
>> > > > >
>> > > > >
>> > > > > _______________________________________________
>> > > > > Kde-imaging mailing list
>> > > > > Kde-imaging at kde.org
>> > > > > https://mail.kde.org/mailman/listinfo/kde-imaging
>> > > > >
>> > > >
>> > >
>> > >
>> > > _______________________________________________
>> > > Kde-imaging mailing list
>> > > Kde-imaging at kde.org
>> > > https://mail.kde.org/mailman/listinfo/kde-imaging
>> > >
>> >
>>
>>
>> _______________________________________________
>> Kde-imaging mailing list
>> Kde-imaging at kde.org
>> https://mail.kde.org/mailman/listinfo/kde-imaging
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-imaging/attachments/20160624/0c5f0aa5/attachment-0001.html>