[Kde-imaging] Review Request 123918: KPBatchProgressDialog: Port from KDialog to QDialog

[Alexander Potashev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123918/
-----------------------------------------------------------

(Updated Май 28, 2015, 3:20 д.п.)


Review request for Kipi-plugins.


Changes
-------

Tested without cancellation.


Repository: kipi-plugins


Description
-------

Behaviour:
* Clicking "Cancel" does not reject the dialog so it is not closed. This
    is new behaviour.
* Clicking "Close" (after Cancel button changed to Close) accepts and
    closes the dialog.

Implementation details:
* The Cancel/Close button is implemented as Close button in a
    QDialogButtonBox.
* Added method setButtonClose() for turning the "Cancel" button into
    "Close" button. A plugin should call this when some error occurs and
    it cannot continue its job. Because there is nothing to cancel
    anymore, the button should be renamed to "Close".
* The Cancel/Close button has standard text/tooltip/icon/whatsthis
    defined in KF5::WidgetsAddons' KStandardGuiItem.
* The signal cancelClicked() is emitted when user clicks Cancel/Close
    like before.


Diffs
-----

  PORT.KF5/OBSOLETE/jpeglossless/plugin/plugin_jpeglossless.cpp 55bef63f320557bf1100f7a5fc1391f9e612f193 
  common/libkipiplugins/CMakeLists.txt 618cc143ab8e18cec3cd1396efe138755ee8ddb7 
  common/libkipiplugins/dialogs/kpbatchprogressdialog.h 853fa2ec8c4afadc66a7c08994c0aec903e1f15a 
  common/libkipiplugins/dialogs/kpbatchprogressdialog.cpp 4fd2bbd0df8177c9b1791c28e1450772c072c688 
  sendimages/sendimages.cpp de91084912e027330a3b9cff22bac3b6db3fdc3e 

Diff: https://git.reviewboard.kde.org/r/123918/diff/


Testing (updated)
-------

The progress dialog in SendImages can be canceled (by clicking Cancel) and then closed (by clicking the same button again after it changed to "Close"). If I don't cancel it, KMail starts successfully and the Cancel button turns into Close which can then be clicked to close the dialog and remove the temporary files.


Thanks,

Alexander Potashev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-imaging/attachments/20150528/aaa2b15f/attachment-0001.html>