[Kde-imaging] [kipiplugins] [Bug 346053] Add PhotoSphere projection support (EquiRectangular)

[Benjamin Girault]

https://bugs.kde.org/show_bug.cgi?id=346053

--- Comment #9 from Benjamin Girault <benjamin.girault at nebux.org> ---
Your last commit is messy between the cosmetic changes and the actual disabling
of PhotoSphere you enabled too quickly (it was disabled for a reason after all
;-) ), and hard to read. I cannot guarantee you didn't break anything in the
process.

I called it "Google+ Metadata" for the lack of a better name. PhotoSphere is
not explicit to the user, and PhotoSphere was used only on G+ at the time. If
the name is more transparent nowadays, I don't mind changing the name of the
checkbox, but if PhotoSphere is only used by G+ (maybe Google Image now?), then
it's not a good idea to use "PhotoSphere metadata"...

As for your question, if the PhotoSphere checkbox is checked, this triggers in
CreatePtoTask::run the PTOType::Project::EQUIRECTANGULAR setting. In
OptimisationTask::run the "-s" argument to "autooptimiser" is used to optimise
the projection. This parameter is disabled when PhotoSphere is checked, like
you said, such that the projection set in CreatePtoTask::run should be used.

Everything should be in place to tell the Hugin CLI tools to use the
equirectangular projection. If I remember correctly, I disabled it because I
couldn't get the G+ 3D viewer to be triggered when submitting panoramas. I
won't have the time to dive into it anytime soon, so if anyone is interested, I
suggest checking the projection type in the various pto files created during
the process (if the projection is indeed the issue):
 - Manager::cpFindPtoData().project.projection
 - Manager::cpCleanPtoData().project.projection
 - Manager::autoOptimisePtoData().project.projection
 - Manager::viewAndCropOptimisePtoData().project.projection
 - ( Manager::previewPtoData().project.projection )
 - ( Manager::panoPtoData().project.projection )
The check can be done in the importwizard/* classes quite easily.

-- 
You are receiving this mail because:
You are the assignee for the bug.