[Kde-imaging] Review Request 123994: KPDialogBase: Move code for getting help button to a helper method

[Gilles Caulier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123994/#review81156
-----------------------------------------------------------


Patch sound fine for me

- Gilles Caulier


On June 3, 2015, 3:21 p.m., Alexander Potashev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123994/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 3:21 p.m.)
> 
> 
> Review request for Kipi-plugins.
> 
> 
> Repository: kipi-plugins
> 
> 
> Description
> -------
> 
> KPDialogBase: Move code for getting help button to a helper method
> 
> 
> Diffs
> -----
> 
>   common/libkipiplugins/dialogs/kptooldialog.h d37de165a45e04b169a0a40cf5fec560842c8ff5 
>   common/libkipiplugins/dialogs/kptooldialog.cpp dd3da4cbd2f73d906e5c62b3e882932fd5fa7e5a 
> 
> Diff: https://git.reviewboard.kde.org/r/123994/diff/
> 
> 
> Testing
> -------
> 
> Help menu still works in Panorama's KPOutputDialog declared in PreProcessingPage::slotShowDetails(), tested together with https://git.reviewboard.kde.org/r/123993/
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-imaging/attachments/20150604/fb7a5e33/attachment.html>