[Kde-imaging] Review Request 123993: KPOutputDialog: Rewrite without inheritance from KPToolDialog

[Gilles Caulier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123993/#review81147
-----------------------------------------------------------


Patch fine for me

- Gilles Caulier


On June 3, 2015, 3:22 p.m., Alexander Potashev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123993/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 3:22 p.m.)
> 
> 
> Review request for Kipi-plugins.
> 
> 
> Repository: kipi-plugins
> 
> 
> Description
> -------
> 
> KPOutputDialog does not need all many features of KPToolDialog or
> KDELibs4's KDialog. Thus we make KPToolDialog easier to port away from
> KDialog.
> 
> Also added an "edit-copy" icon to the button "Copy to Clipboard".
> 
> 
> Diffs
> -----
> 
>   common/libkipiplugins/dialogs/kpoutputdialog.h f7b96e0feaf2935e55e99a149aa51d11502ad65f 
>   common/libkipiplugins/dialogs/kpoutputdialog.cpp 32e00f272b928be4577198c56a780f589e402a2f 
>   common/libkipiplugins/dialogs/kptooldialog.cpp dd3da4cbd2f73d906e5c62b3e882932fd5fa7e5a 
> 
> Diff: https://git.reviewboard.kde.org/r/123993/diff/
> 
> 
> Testing
> -------
> 
> Tested with Panorama's KPOutputDialog declared in PreProcessingPage::slotShowDetails().
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-imaging/attachments/20150603/45965969/attachment.html>