[Kde-imaging] Review Request 115373: imageshackexport: i18n: Fix untranslatable user-visible strings

[Alexander Potashev]

> On Jan. 30, 2014, 8:31 p.m., Burkhard Lück wrote:
> > Ship it from KDE Translation Team
> > 
> > @ Alexander Potashev:
> > From my pYou do not need a ship it from devels, untranslated strings due 
> > to missing 18n() calls like here I would commit without review

I posted this on ReviewBoard because there were strings which are added into a QStringList. And yes - I've just re-read the patch and found a mistake: the strings for insertion into "valueList" in ImageshackWidget::updateResizeOpts() should not be translatable, because they will be sent to the server as parameter values.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115373/#review48656
-----------------------------------------------------------


On Jan. 30, 2014, 7:42 p.m., Alexander Potashev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115373/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 7:42 p.m.)
> 
> 
> Review request for Kipi-plugins and Gilles Caulier.
> 
> 
> Repository: kipi-plugins
> 
> 
> Description
> -------
> 
> Fix untranslatable user-visible strings.
> 
> 
> Diffs
> -----
> 
>   imageshackexport/imageshackwidget.cpp 5717641 
> 
> Diff: https://git.reviewboard.kde.org/r/115373/diff/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-imaging/attachments/20140131/7949044d/attachment.html>