[Kde-imaging] Review Request 119654: Fixes for OpenCV detection (again)

[Vadim Zhukov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119654/
-----------------------------------------------------------

Review request for Kipi-plugins.


Repository: kipi-plugins


Description
-------

Here is a patch for two problems arised between my OpenCV linking-related patches went in and 4.2.0 release:

1. Second call to FIND_PACKAGE() in MacroOpenCV.cmake should use ${OPENCV_REQUIRED_COMPONENTS}, too. This problem exists in digikam and libkface repos as well.
2. "contrib" found its way back to kipi-plugins CMakeLists.txt. It looks like a copy-paste error, too. I could be wrong, but things (red eye removal tool) do work fine on OpenBSD without it.


Diffs
-----

  CMakeLists.txt f242f30 
  cmake/modules/MacroOpenCV.cmake 476607f 

Diff: https://git.reviewboard.kde.org/r/119654/diff/


Testing
-------

OpenBSD/i386 5.6-BETA, KDE 4.13.3, Digikam SC 4.2.0.


Thanks,

Vadim Zhukov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-imaging/attachments/20140807/bfd06abc/attachment.html>