[Kde-imaging] Review Request 109121: Added a ListPages class, based on QueryImages

[Adrián Chaves Fernández]

> On Feb. 24, 2013, 7:45 p.m., Gilles Caulier wrote:
> > Thanks Adrian for your patch.
> > 
> > I'm not maintainer of libmediawiki. Please set these people in CC to review your code :
> > 
> > Guillaume Hormiere <hormiere.guillaume at gmail.com>
> > Alexandre Mendes <alex.mendes1988 at gmail.com>
> > Guillaume Paumier <guillom.pom at gmail.com>
> > 
> > Thanks in advance
> > 
> > Gilles Caulier

Will do, thanks.


- Adrián


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109121/#review27974
-----------------------------------------------------------


On Feb. 24, 2013, 8:19 p.m., Adrián Chaves Fernández wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109121/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2013, 8:19 p.m.)
> 
> 
> Review request for Kipi-plugins and Guillaume Paumier.
> 
> 
> Description
> -------
> 
> I’ve added a new class to the library, ListPages, that provides a list of all the pages in the main namespace of the target MediaWiki site. It’s closely based on the existing QueryImages class.
> 
> 
> Diffs
> -----
> 
>   libmediawiki/CMakeLists.txt ad37e9a 
>   libmediawiki/querylistallpages.h PRE-CREATION 
>   libmediawiki/querylistallpages.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109121/diff/
> 
> 
> Testing
> -------
> 
> I though about writting an unit test, based on the QueryImages one too. However, I noticed the QueryImages test data was mainly based on comparing cases where three images are returned, while this new class is meant to retrieve a lot of pages, 500 by 500.
> 
> I did test the new code on a pet project of mine, which is the reason for me to send this patch in the first place. I actually found the libmediawiki.so file by chance while writing a Qt/C++ library for MediaWiki sites from scratch — I was really lucky. I took the chance to add the library to the list here: http://www.mediawiki.org/wiki/API:Client_code#C.2B.2B
> 
> 
> Thanks,
> 
> Adrián Chaves Fernández
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-imaging/attachments/20130224/8d98dbf8/attachment.html>