[Kde-imaging] [Digikam-devel] Coverty Reports traces...

Gilles Caulier caulier.gilles at gmail.com
Tue Feb 5 08:09:14 UTC 2013


yes, it's fileformatter.py :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/project/scripts/fileformatter.py

Which coding style is respected with this script ?

Gilles


2013/2/5 Andi Clemens <andi.clemens at gmail.com>

> I had added a script for automatically formatting code... should be in the
> utilities/scripts folder if I'm not wrong (I currently have no source code
> available).
>
> Andi
>
>
> 2013/2/5 Gilles Caulier <caulier.gilles at gmail.com>
>
>> Done. I review all code and fixed coding style for better readability.
>> It's not easy. Some part of code and very difficult to parse. Coding style
>> is very important to share code with other developer.
>>
>> I don't blame nobody here. But it's a strict rule that we need to follow,
>> to be sure that code can be maintained by all developers...
>>
>> I think code is more easy to handle now. I take a care to don't break
>> logic everywhere. Also, when it's possible to constify pointers is always
>> more safe, when it's possible.
>>
>> Gilles
>>
>>
>> 2013/2/4 Angelo Naselli <anaselli at linux.it>
>>
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> Il 04/02/2013 12:34, Angelo Naselli ha scritto:
>>> > Il 04/02/2013 11:21, Gilles Caulier ha scritto:
>>> >> cropframe .cpp fixes will be very simple. Some members are not
>>> >> initialized in constructor.
>>> > I should have missed that last night...
>>> hmm Gilles can you check it better? i should have committed
>>> it last night as well...
>>>
>>> Thanks
>>>         Angelo
>>> -----BEGIN PGP SIGNATURE-----
>>> Version: GnuPG v1.4.12 (GNU/Linux)
>>> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>>>
>>> iEYEARECAAYFAlEQFH8ACgkQqEs9DA4DquAGxgCffCpiF4FxLMAsYsZx4du4mQcK
>>> ueMAoJeVK99uhDp0IzNomc66ScYEOjSx
>>> =CFZ5
>>> -----END PGP SIGNATURE-----
>>> _______________________________________________
>>> Kde-imaging mailing list
>>> Kde-imaging at kde.org
>>> https://mail.kde.org/mailman/listinfo/kde-imaging
>>>
>>
>>
>> _______________________________________________
>> Kde-imaging mailing list
>> Kde-imaging at kde.org
>> https://mail.kde.org/mailman/listinfo/kde-imaging
>>
>>
>
> _______________________________________________
> Kde-imaging mailing list
> Kde-imaging at kde.org
> https://mail.kde.org/mailman/listinfo/kde-imaging
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-imaging/attachments/20130205/bcea4e21/attachment.html>


More information about the Kde-imaging mailing list