[Kde-imaging] [Bug 286018] Pano Tool and ExpoBlend tool do not work on OS X [patch]

[Ananta Palani]

https://bugs.kde.org/show_bug.cgi?id=286018





--- Comment #46 from Ananta Palani <anantapalani gmail com>  2012-01-23 16:26:03 ---
(In reply to comment #45)
> (In reply to comment #44)
> > Doesn't crash anymore (pto2mk.exe was crashing)
> 
> How could you tell that? Was it because you ran it on your own and found out it
> was crashing? If not, the user should not be aware of a crash of pto2mk, only
> that it is not detected, or that the version is detected as not recent
> enough...

On Windows, if a program crashes a window is diplayed informing the user of
this and asking what to do, such as submitting a bug report to Microsoft,
restarting the program, or (if installed) launching debug tools. When the scan
happened, one of these windows would pop up telling me of that pto2mk.exe
crashed.

> > > > 3. relaunch of panorama wizard within a given digikam session does not re-check
> > > > existence of hugin apps (only after digikam is restarted and the panorama
> > > > creator reopened does it detect moved or missing apps), so if the hugin is
> > > > installed/uninstalled/moved while digikam is opened then the panorama app may
> > > > not notice the change.
> > > 
> > > Good point (I didn't thought of that because I'm using the standalone version
> > > of the plugin for testing). It should be working now.
> > 
> > Unfortunately this is not working :(
> 
> Then, I have to setup a test environment for that.

Perhaps destroying the panorama wizard after it is closed/finished would be
sufficient to re-initiate the check?

> > 1. After locating one of the executables, all the remaining executables are not
> > located automatically in the same path. Instead, each has to be located
> > individually. This worked before your changes yesterday.
> 
> Done (I introduced a bug during one of my commits from yesterday).

Works great now, thanks.

> > 2. If an error occurs at some point in processing, the 'Next' button is still
> > available.
> 
> Damn it! I fixed the 'Back' button, and now the 'Next' one doesn't work :'( Can
> you tell me at which point of the process you've seen this behavior? I don't
> think the bug is present at any point of the process (for example, it is
> working as expected in the intro page...)

I've seen it happen several times. I can reproduce it on the 'Pre-Processing
Images' page after 'Pre-processing has failed' for instance if I move the
location of hugin without updating the panorama wizard, and also on the
'Preview and Post-Processing' page after the make file could not be processed
(error shown is 'Preview cannot be processed') which occurs if the nona is not
in the location the makefile shows.

I also noticed a new problem, so in total there are 3 minor problems:

1. On the final page of the wizard the user is asked to choose a 'file name
template'. If a name is chosen which is the same as an existing image then
clicking 'Finish' does nothing and no warning/error is presented to the user.
Only after changing the name to something new does 'Finish' do anything. So if
a warning could be presented to the user, that would be great.

2. Same error as 2 before, next button still functional after error

3. Same error as 3 before, relaunch of panorama wizard does not check if
executables are still in the same locations

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.