[Kde-imaging] [Bug 303980] Batch DNG conversion of multiple raw files produces multiple files of the last raw file in queue

[Gilles Caulier]

https://bugs.kde.org/show_bug.cgi?id=303980

--- Comment #9 from Gilles Caulier <caulier.gilles at gmail.com> ---
Smit,

Right. the problem is the re-entancy with DNGConverter core implementation.

In fact, it's wrong to share DNGWriter instance between ActionThread private
container with all Tasks started in separated threads.

To be clear, nothing must be shared between ActionThread and Task. For each
Task instance, a DNGWriter instance must be created.

Also, there is another point where implementation is wrong : the temporary file
created by each Task instance. The temporary file name is based on timestamp
where granularity is the seconds. This is not enough. We must not use timestamp
to create unique temporary file. I already explain the problem with my comment
#5.

You can take look how i manage Task and ActionThread clasess in digiKam Batch
Queue Manager that i recently parallelized. I see the same problem during port.
Look here :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/queuemanager/manager/actionthread.cpp

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/queuemanager/manager/task.cpp

Note : RAW converter kipi-plugins has exactly the same implementation and must
be fixed in the same way.

Do you will able to manage these problem before 3.0.0 final release planed
around 25 January 2013 ?

Gilles Caulier

-- 
You are receiving this mail because:
You are the assignee for the bug.