[Kde-imaging] [Bug 288159] New: i18n done horribly in PhotoLayoutsEditor

[Alexander Potashev]

https://bugs.kde.org/show_bug.cgi?id=288159

           Summary: i18n done horribly in PhotoLayoutsEditor
           Product: kipiplugins
           Version: unspecified
          Platform: Archlinux Packages
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: PhotoLayoutsEditor
        AssignedTo: kde-imaging at kde.org
        ReportedBy: aspotashev at gmail.com


Version:           unspecified (using KDE 4.7.3) 
OS:                Linux

Here are the i18n problems that I have found in PhotoLayoutsEditor:
1. Names of many `QUndoCommand`s are weird, for example: "Border changed",
should be "Change Border" or "Border Change".
2. Missing i18n() call for "Delete item" in
photolayoutseditor/widgets/canvas/Scene.cpp at line 663.
3. Missing i18n() calls for "Color", "Image" and "Pattern" in
photolayoutseditor/widgets/tools/CanvasEditTool.cpp around the line 85.
4. Other mistakes by `msgid`:

|||   hardcoded bracket
#: effects/PixelizePhotoEffect.cpp:123
msgid "Pixelize ["

|||   add "..."
#: plugin/photolayoutseditor.cpp:256
msgctxt "Export current frame layout to image file"
msgid "Export"

|||   add "..."
#: plugin/photolayoutseditor.cpp:298
msgctxt "Configure grid lines visibility"
msgid "Setup grid"

|||   add "..."
#: plugin/photolayoutseditor.cpp:302
msgctxt "Configure canvas size"
msgid "Change canvas size"

|||   can't -> cannot
#: plugin/photolayoutseditor.cpp:423
msgid "Can't read image file."

|||   remove "!"
#: plugin/photolayoutseditor.cpp:539
msgid "There is nothing to save!"

|||   remove "!"
#: plugin/photolayoutseditor.cpp:567
msgid "Unexpected error while saving an image!"

|||   remove "!"
#: plugin/photolayoutseditor.cpp:705 widgets/canvas/Canvas.cpp:884
msgid "Invalid image size!"

|||   hardcoded concatenation
#: threads/ImageLoadingThread.cpp:171 threads/ImageLoadingThread.cpp:247
msgid "Loading "

|||   add "..."
#: threads/ImageLoadingThread.cpp:185 threads/ImageLoadingThread.cpp:275
msgid "Decoding image"

|||   add "..."
#: threads/PhotoItemLoader.cpp:102 threads/TextItemLoader.cpp:97
msgid "Finishing"

|||   add "..."
#: threads/TextItemLoader.cpp:60
msgid "Reading text"

|||   add "..."
#: threads/TextItemLoader.cpp:76
msgid "Reading color"

|||   add "..."
#: threads/TextItemLoader.cpp:87
msgid "Reading fonts"

|||   add "..."
#: threads/AbstractPhotoItemLoader.cpp:75
msgid "Reading properties"

|||   add "..."
#: threads/AbstractPhotoItemLoader.cpp:136
msgid "Reading borders"

|||   add "..."
#: threads/AbstractPhotoItemLoader.cpp:162
msgid "Reading effects"

|||   add "..."
#: threads/AbstractPhotoItemLoader.cpp:179
msgid "Reading cropping shape"

|||   add "..."
#: threads/CanvasSavingThread.cpp:75
msgid "Creating canvas"

|||   add "..."
#: threads/CanvasSavingThread.cpp:125
msgid "Saving scene"

|||   add "..."
#: threads/CanvasSavingThread.cpp:144
msgid "Encoding data"

|||   add "..."
#: threads/CanvasSavingThread.cpp:155
msgid "Writing data to file"

|||   hardcoded plural form
#: widgets/canvas/ScalingWidgetItem.cpp:482
msgid "Scale items"

|||   hardcoded plural form
#: widgets/canvas/ScalingWidgetItem.cpp:497 widgets/canvas/Scene.cpp:332
msgid "Move items"

|||   hardcoded plural form
#: widgets/canvas/RotationWidgetItem.cpp:45
msgid "Rotate item"

|||   hardcoded plural form
#: widgets/canvas/RotationWidgetItem.cpp:275
msgid "Rotate items"

|||   hardcoded plural form
#: widgets/canvas/Scene.cpp:281 widgets/canvas/Scene.cpp:289
msgid "Add item"

|||   hardcoded plural form
#: widgets/canvas/Scene.cpp:289 widgets/canvas/Scene.cpp:610
msgid "Add items"

|||   hardcoded plural form
#: widgets/canvas/Scene.cpp:471
msgid "Crop item"

|||   use plurals
|||   remove "!"
#: widgets/canvas/Scene.cpp:1385
#, kde-format
msgid "Unable to create %1 element(s)!"

|||   the most badly hardcoded i18n I have ever seen
#: widgets/canvas/Scene.cpp:1492
#, kde-format
msgid "Are you sure you want to delete %1 selected item%2?"

|||   "%s"?! append()?! GNOME guys, are you here?
#: widgets/items/PhotoItem.cpp:141
#, c-format
msgid ""
"Can't find image file in this location:\n"
" %s\n"
"\n"
"Would you like to set new location of this file?\n"
"If not this image will be removed from the composition."


Reproducible: Always


Actual Results:  


Expected Results:

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.