[Kde-imaging] [Bug 233438] Digikam crash when editing raw images on OS X

[Alex Tutubalin]

https://bugs.kde.org/show_bug.cgi?id=233438





--- Comment #6 from Alex Tutubalin <lexa lexa ru>  2010-10-16 21:22:50 ---
  Brad,

I've found your compiler version details in KDE bugs site (see my reply 
in bug tracker)

There are two significant differences:

  1) There was a change in OpenMP directives in wavelet denoise in 
0.10-Beta1. So, 0.10.0 (stable release) may behave differently with 
0.8.5 you use
  2) Compiler version is slightly differ.

Anyway, I cannot reproduce the problem for now.

I thing, it is better to continue discussion in KDE bugs interface, not 
in private mail.

On 10/16/2010 10:54 PM, brad wrote:
> https://bugs.kde.org/show_bug.cgi?id=233438
>
>
>
>
>
> --- Comment #4 from brad<bkn ithryn net>   2010-10-16 20:54:45 ---
> An update on this bug. I just sent this message to the kdegraphics-devel list
> and the libraw mailing list. It turns out the bug is in dcraw_common.cpp where
> the OpenMP version of wavelet_denoise() is used on OS X, but the OpenMP version
> crashes under OS X (see above). The normal version of the wavelet_denoise
> executes just fine under OS X. Below is the message to the mailing lists.
>
> -----
>
> I've been fighting a crash w/ digikam for months. I reported the bug here if>
> you want more info:
> https://bugs.kde.org/show_bug.cgi?id=233438
>
> The bug is in libraw/internal/dcraw_common.cpp. It appears there are two
> versions of the wavelet_denoise() function, one uses OpenMP for parallel
> processing, the other is just a normal linear executing function. When this
> file is compiled under OS X it compiles the OpenMP version of the function,
> which crashes on OS X. The simple fix is to use the linear version of
> wavelet_denoise() on OS X. Below is an ad-hoc patch:
>
> dcraw_common.cpp: 3186
>
> +/* the OpenMP parallel version of this function appears to be crashing under
> OS
> + * X; therefor just use the non OpenMP version of this funciton on OS X
> + */
> +#if !defined(_OPENMP) || defined(__APPLE__) || defined(__MACOSX__)
> -#ifndef(_OPENMP)
> void CLASS wavelet_denoise()$
> {
>
>
> I am not familiar with OpenMP nor do i understand how dcraw_common.cpp is
> generated so it is difficult for me to debug. If someone is willing to give me
> info how these things work i can try to get the OpenMP version work on OS X.
>

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.