[Kde-imaging] Re: Review Request: Bug fix in facebook uploader/downloader kipi-plugin

[Viranch Mehta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5773/
-----------------------------------------------------------

(Updated 2010-11-06 09:54:44.414824)


Review request for kipi-plugins.


Summary
-------

New function createButtons() created. It re-creates the User1 button and
helpMenu. The m_about definition moved to top in constructor. createButtons()
is called:
1. inside constructor
2. in reactivate()
3. in slotStartTransfer() (for changing back to 'Cancel' from 'Close')
4. in uploadNextPhoto() (for changing 'Cancel' to 'Close')
5. in downloadNextPhoto() (for changing 'Cancel' to 'Close')
Also, the 'start' button does not disappear after uploading, to enable user to
upload new photos by adding more of them in the list.

Please let me know if anything is wrong since I started only recently.


This addresses bug 251860.
    https://bugs.kde.org/show_bug.cgi?id=251860


Diffs
-----

  trunk/extragear/graphics/kipi-plugins/facebook/fbwindow.h 1191657 
  trunk/extragear/graphics/kipi-plugins/facebook/fbwindow.cpp 1191657 

Diff: http://svn.reviewboard.kde.org/r/5773/diff


Testing (updated)
-------

I have tested every test-case, works fine. The small problem I see is every time the button box is refreshed and it is clearly seen by the user. This might not be desirable.

Tested with Gwenview, BTW.


Thanks,

Viranch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-imaging/attachments/20101106/106fbb09/attachment-0001.htm