[Kde-imaging] [Bug 212116] Rename images: sorting does not work [patch]

[Gilles Caulier]

https://bugs.kde.org/show_bug.cgi?id=212116


Gilles Caulier <caulier.gilles at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2009-10-28 14:41:33 ---
SVN commit 1041769 by cgilles:

apply patch #37922 by Martin EngelMann. 

Comments from Martin :

"For this fix a hidden column is created in the BatchProcessImagesList that
holds
the sort key for the BatchProcessImagesItems. This sort key is created based on 
the selected sorting criterium.

The already present part of the interface in BatchProcessImagesItem has been
replaced by get and set function for the sortkey. The column of the sortkey is
made available by the static function columnOfSortKey.

In batchprocessimageslist.cpp:44 the index of the column with the sort key is
used instead of calling the static function to avoid an include dependency with
batchprocessimagesitem.h. If this doesn't hurt. The function should be called  
instead of using the magic number.

I've deleted the already commented out function BatchProcessImagesItem::compare
because I don't see any further use of it."

BUGS: 212116



 M  +2 -1      CMakeLists.txt  
 M  +16 -21    batchprocessimagesitem.cpp  
 M  +4 -7      batchprocessimagesitem.h  
 M  +2 -1      batchprocessimageslist.cpp  
 M  +4 -8      renameimageswidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1041769

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.