[Kde-imaging] [Bug 193685] Set permissions on a per-photo base

[Vardhman]

https://bugs.kde.org/show_bug.cgi?id=193685


Vardhman <vardhman at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
                 CC|                            |vardhman at gmail.com
         AssignedTo|kde-imaging at kde.org         |p.edelman at gmx.net
     Ever Confirmed|0                           |1




--- Comment #4 from Vardhman <vardhman gmail com>  2009-05-31 16:31:50 ---
I have few suggestions/questions regarding the patch, I also wonder what is the
standard procedure for patch acceptance/submission. Is it that once I approve
the change patch submitter will submit the same or should I submit this patch ?

comments:flickrlist.cpp/.h is a file added by you, so you should add your name
in the Copyright(c), since this file is pretty much all new you should not need
to write name of the authors of the original files from where this class is
derived.

Please split the line which are > 80/100 columns to wrap them to 80/100 for
better readability 
+    setToolTip (KIPIPlugins::ImagesListView::User1, i18n("Check if photo
should be publicly visible or use Upload options tab to specify this for all
images"));
question: In slotAddImages, if all the image have is_family selected you are
setting is_family to false, I am not sure I understand that, could you explain
?

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.