[Kde-imaging] [Bug 182743] Bug: "advanced slide show" renders system unresponsive on large image collections

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=182743





--- Comment #10 from Andi Clemens <andi clemens gmx net>  2009-07-19 11:24:14 ---
I have no cache enabled (you can set it in the dialog).
We are filling this KUrl map in three different places, and I don't understand
why.

First, we get all images from KIPICollection Interface, and find out which are
selected:
http://lxr.kde.org/source/extragear/graphics/kipi-plugins/advancedslideshow/maindialog.cpp#552

Then we update this list whenever something happens in the config dialog.
And in the end when the slideshow is loaded, we get this list again, without
using the sharedData:
http://lxr.kde.org/source/extragear/graphics/kipi-plugins/advancedslideshow/plugin_advancedslideshow.cpp#192

The strange thing in the code above: We can never get the selected images, so a
slideshow will always display a full album. But the slideshow config has a
radiobutton to only display selected images (which is always grayed out
anyway).
Also in the first code reference, we calculate the images by getting all images
from the interface and keeping only those that belong to the current album
path.
When the slideshow is started (second code reference), we just ignore all those
urls and get the images with interface->currentAlbum.

This looks like a misconception to me, but maybe I don't understand the purpose
here.

Anyway if the plugin is caching, it definitely doesn't have to do this on
startup, only when pressing "Start Slideshow". And even then it should cache
like 4-5 images, not more.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.