[Kde-imaging] Re: [PATCH] GwenView: Proper icon for Go to Previous Image & Go to Next Image

[James Richard Tyrer]

Aurélien Gâteau wrote:
> James Richard Tyrer wrote:
>> Aurélien Gâteau wrote:
>>> James Richard Tyrer wrote:
>>>
>>>> However, assignment of icons with the new names is supposed to be based 
>>>> on function and I consider it a bug that you are using the 
>>>> "media-seek-*" icons since GwenView is not a media player (it does not 
>>>> play audio and/or video).
>>> I consider images to be media.
>> Yes, you can make a case for that.  There is also a case for consistency 
>> form app to app.
> 
> Gwenview used to use back/forward history icons for previous/next 
> actions. It confused a lot of users because they rightly associated 
> these icons with navigating the history, while it was in fact about 
> navigating the image list.
> Your icons look quite similar to the back/forward history icons so I 
> think it will lead to confusion and in the end, reduce consistency.
> 
> There is already a set of generic arrows: 
> arrow-{up,down,left,right}{-double,}.png. Do we really need more?
> 
As I said, I was told that the "arrow-*" icons were deprecated.  The new 
icon names are supposed to describe the purpose of the icon rather than 
what the icon looks like.  So, yes we need different icons as the 
"arrow-*" icons will be dropped as soon as they are no longer being used.

-- 
JRT