[Kde-imaging] Another possible factorization in libkdcraw...

[Angelo Naselli]

FYI, since not all the developers are digikam's.

Angelo

----------  Messaggio inoltrato  ----------

Oggetto: [Digikam-devel] Another possible factorization in libkdcraw...
Data: martedì 21 ottobre 2008
Da: "Gilles Caulier" <caulier.gilles at gmail.com>
A: "digiKam developers" <digikam-devel at kde.org>

Andi,

Look like with KDE4, we have duplicates implementations :

from digiKam core :
http://websvn.kde.org/trunk/extragear/graphics/digikam/libs/widgets/common/squeezedcombobox.cpp?revision=727772&view=markup

from kipi-plugins core :
http://websvn.kde.org/trunk/extragear/graphics/kipi-plugins/common/libkipiplugins/squeezedcombobox.cpp?revision=816159&view=markup

It's the same implementation. only namespace changes.

The best candidate to host this common widget is libkdcraw. Also, we can use
it in libkdcraw instead QComboBox/KComboBox. Of course, all place in
digiKam/kipi-plugins which use squeezedcombobox must be adapted to use
KDCraw namespace and header.

But we must don't use this widget at other place, because regression tests
need to be done, and it can take a while.

To resume, the widget is the same than q QComboxo excepted that it squezze
long combo text to prevent huge layout in gui.

Best

Gilles Caulier

-------------------------------------------------------

----------  Messaggio inoltrato  ----------

Oggetto: Re: [Digikam-devel] Another possible factorization in libkdcraw...
Data: martedì 21 ottobre 2008
Da: Andi Clemens <andi.clemens at gmx.net>
A: digikam-devel at kde.org

So right now we should move it to libkdcraw and replace all sqeezeboxes 
defined in digikam and kipi-plugins? ... ok.
I can do that.
If this is done, I will also use it for libkdcraw. The rest could be discussed 
later when we think that the widget is needed in more places.

Andi


On Tuesday 21 October 2008 10:00:48 Gilles Caulier wrote:
> Andi,
>
> Look like with KDE4, we have duplicates implementations :
>
> from digiKam core :
> http://websvn.kde.org/trunk/extragear/graphics/digikam/libs/widgets/common/
>squeezedcombobox.cpp?revision=727772&view=markup
>
> from kipi-plugins core :
> http://websvn.kde.org/trunk/extragear/graphics/kipi-plugins/common/libkipip
>lugins/squeezedcombobox.cpp?revision=816159&view=markup
>
> It's the same implementation. only namespace changes.
>
> The best candidate to host this common widget is libkdcraw. Also, we can
> use it in libkdcraw instead QComboBox/KComboBox. Of course, all place in
> digiKam/kipi-plugins which use squeezedcombobox must be adapted to use
> KDCraw namespace and header.
>
> But we must don't use this widget at other place, because regression tests
> need to be done, and it can take a while.
>
> To resume, the widget is the same than q QComboxo excepted that it squezze
> long combo text to prevent huge layout in gui.
>
> Best
>
> Gilles Caulier

_______________________________________________
Digikam-devel mailing list
Digikam-devel at kde.org
https://mail.kde.org/mailman/listinfo/digikam-devel

-------------------------------------------------------

----------  Messaggio inoltrato  ----------

Oggetto: Re: [Digikam-devel] Another possible factorization in libkdcraw...
Data: martedì 21 ottobre 2008
Da: "Gilles Caulier" <caulier.gilles at gmail.com>
A: "digiKam developers" <digikam-devel at kde.org>

2008/10/21 Andi Clemens <andi.clemens at gmx.net>

> So right now we should move it to libkdcraw and replace all sqeezeboxes
> defined in digikam and kipi-plugins? ... ok.


yes.


>
> I can do that.
> If this is done, I will also use it for libkdcraw. The rest could be
> discussed
> later when we think that the widget is needed in more places.
>

yes.

Gilles

-------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-imaging/attachments/20081021/a9919bb1/attachment.sig