[Kde-imaging] [PATCH] GwenView: Proper icon for Go to Previous Image & Go to Next Image

[James Richard Tyrer]

The Oxygen team committed new icons: "go-previous-page" & "go-next-page" 
and used those names for the two KDE Standard Actions which GwenView was 
using.  Apparently they didn't understand that these two KDE Standard 
actions were serving two functions.  Actually, I think it is better that 
they do not serve two purposes and that will mean changes to the code 
that will require approval of KDE-Core.

I have committed more generic icons "go-*-view" that are not a page 
specific metaphor which should work for other uses including GwenView.

This small patch should fix the problem:

Index: gwenview/app/mainwindow.cpp
===================================================================
--- gwenview/app/mainwindow.cpp (revision 902758)
+++ gwenview/app/mainwindow.cpp (working copy)
@@ -299,13 +299,13 @@ struct MainWindow::Private {
                         mWindow, SLOT(reduceLevelOfDetails()) );

                 mGoToPreviousAction = 
view->addAction("go_previous",mWindow, SLOT(goToPrevious()));
-               mGoToPreviousAction->setIcon(KIcon("media-seek-backward"));
+               mGoToPreviousAction->setIcon(KIcon("go-previous-view"));
                 mGoToPreviousAction->setText(i18nc("@action Go to 
previous image", "Previous"));
                 mGoToPreviousAction->setToolTip(i18n("Go to Previous 
Image"));
                 mGoToPreviousAction->setShortcut(Qt::Key_Backspace);

                 mGoToNextAction = view->addAction("go_next",mWindow, 
SLOT(goToNext()));
-               mGoToNextAction->setIcon(KIcon("media-seek-forward"));
+               mGoToNextAction->setIcon(KIcon("go-next-view"));
                 mGoToNextAction->setText(i18nc("@action Go to next 
image", "Next"));
                 mGoToNextAction->setToolTip(i18n("Go to Next Image"));
                 mGoToNextAction->setShortcut(Qt::Key_Space);

and then you will have icons as shown in the attached screen shot and 
will not have to borrow icons intended for other use.

If this is OK, I can commit it for you.

-- 
JRT

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gwenview1.png
Type: image/png
Size: 27797 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-imaging/attachments/20081230/0a55c497/attachment-0001.png