[Kde-imaging] Proposed enhancement to KIPIPlugins::ImagesList

[Gilles Caulier]

2008/12/9 Luka Renko <lure at kubuntu.org>

> On Tuesday 09 December 2008 10:57:06 Andi Clemens wrote:
> > In Qt4, you normally don't need a parent at all, it will be mapped anyway
> > when adding to a layout. I usually don't provide parents to Layout and
> > Widgets, because it is easier for me to read it that way.
> >
> > But since we use switch later on and in case of "NoButtons" don't add the
> > buttons to a layout, I need to set a parent in ctor of the buttons,
> > otherwise we have a memory leak.
>
> Good catch!
>
> > About the plainWidget: Right now the only plugin that uses it (and maybe
> > the only one that ever will) is RemoveRedEyes. Since I use buttons on the
> > right, I think it is ok to skip the plainWidget as you mentioned in
> > 'NoButtons' mode.
>
> OK, I though so.
>
> Thanks for reviewing, testing and committing it!


I'm waiting your new plugin code for including it officially to next beta
release. I will test if it compile fine under Windows.

Please commit your code on svn when it ready...

Question : it require a specific external depency ?

Best

Gilels
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-imaging/attachments/20081209/514f9daf/attachment.htm