[Kde-imaging] [Bug 149666] [PATCH] iPod Export kipi plugin cannot be disabled at compile time when libgpod is present on system

[Matěj Laitl]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149666         




------- Additional Comments From strohel gmail com  2007-09-30 19:16 -------
> We're talking about plugins and even if i can see the external lib dependency point, i can't get why for user should be easier removing a lib dependency instead of a plugin. I mean you talked about ipod-export and said that user can think he/she doesn't need it, so he/she should disable libgpod (in your example), that sonunds odd to me, i would disable the plugin instead.

Oh yes, you are right..

So, I imagine we could solve it like this:
* Create a section in configure.in.in, with:
    1. build_libgpod=no ### for every conditionally needed library
    2. AC_ARG_ENABLE(ipodexport,
           AC_HELP_STRING([--disable-ipodexport], [disable iPod Export plugin. Requires libgpod. [default=enable]]),
           [enable_ipodexport="$enableval"; build_libgpod="$enableval"],
           [enable_ipodexport=yes; build_libgpod=check]
       )
       ### for every plugin
* envelop every check for conditionally needed library in:
    if test "x$build_libgpod" != "xno"; then    (already done for libgpod)
    (and die if build_libgpod===yes and not found, but do not die if build_libgpod=check)
* add AM_CONDITIONAL(compile_XX, [test "x$enable_xx" != "xno"]) for plugins that don't already have a AM_CONDITIONAL.
* tweak configure.in.bot not to print "Library not found" for non-needed libs

Anyone has clue how to do it without writing AC_ARG_ENABLE for every plugin?

Also, I changed --with-feature to --enable-feature, see http://www.gnu.org/software/autoconf/manual/autoconf-2.57/html_node/autoconf_130.html and http://www.gnu.org/software/autoconf/manual/autoconf-2.57/html_node/autoconf_131.html

Comments welcome,
    Matěj