[Kde-imaging] [Bug 145771] Gnome Desktop crashes and restarts when select Cancel option for Mpeg Slideshow plugin

Angelo Naselli anaselli at linux.it
Sun Jun 3 23:49:46 CEST 2007


------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=145771         
anaselli linux it changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From anaselli linux it  2007-06-03 23:49 -------
SVN commit 671143 by anaselli:

sigkill wrongly sent to application 
BUG: 145771

 M  +3 -2      kimg2mpg.cpp  


--- branches/extragear/kde3/libs/kipi-plugins/mpegencoder/kimg2mpg.cpp #671142:671143
 @ -703,8 +703,9  @
   connect(m_Proc, SIGNAL(receivedStderr(KProcess *,char*,int)),this,
           SLOT(readStderr(KProcess*,char*,int)));
 
+  m_Img2mpgPidNum = -1;
   bool result = m_Proc->start(KProcess::NotifyOnExit , KProcess::All);
-
+  
   if(!result)
     {
     QString str = i18n("Cannot start 'images2mpg' bash script : fork failed.");
 @ -998,7 +999,7  @
   {
   m_Encoding = false;
 
-  if (m_Proc)
+  if (m_Proc && m_Img2mpgPidNum > 0)
     {
         ::kill(m_Img2mpgPidNum, SIGKILL);
     }


More information about the Kde-imaging mailing list