[Kde-imaging] extragear/libs/kipi-plugins/rawconverter [POSSIBLY UNSAFE]

[Gilles Caulier]

On Tuesday 10 October 2006 14:59, Angelo Naselli wrote:
> Alle 14:35, martedì 10 ottobre 2006, Gilles Caulier ha scritto:
> > SVN commit 594192 by cgilles:
> >
> > kipi-plugins from trunk : RAW Converter : bye bye external dcraw depency
> > :
> >
> > Raw onverter plugin use a dedicaced dcraw binary program to run. This is
> > mandatory since dcraw author have broken the command line options
> > compatibility with the 8.x serie.
> >
> > Also, dcraw is not available like a library!
> >
> > The dcraw.c source code embeded in plugin is just a copy of official
> > implementation, but this one have been completly tested with plugin.
>
> Does that mean we do have to maintain old dcraw code? Or it's a
> a temporary solution?

No. The code to maintain is the dcrawiface class, and only when we want to 
do !

I want mean that when we want to update the dcraw.c implementation using the 
dcraw offical web page (look in Makefile.am for details), we just need to 
_copy_ the dcraw.c into svn.

After, we check if :

- it compile.
- an option syntax have changed. If yes, dcrawiface.cpp implementation need to 
be fixed
- all regression tests work fine using the plugin.

With this solution (it's definitive) witch is used also with digiKam core, we 
update when we have time to do it. This is the most important. Nothing is 
broken on client computer since we aren't dependant of an external dcraw 
binary provided by the linux dist. We provide it instead !

With digiKam we have recieve a loooooooooots of reports about dcraw release 
incompatibilty. The _main_ problem is than dcraw isn't available like a 
library. It's a _shame_ ! 

This is not a blame here. I love dcraw tool witch provide a Raw file format 
support under Linux. But i'm not alone to ask a real library for that. And 
it's a main problem...

To have discuted by mail with Dave Coffin himself, nothing will be done in 
this way. Look in the dcraw web site for details. The only way than Dave will 
do is to preserve the dcraw command line options with the future dcraw 
releases.

Gilles