[Kde-imaging] exiv2 (Re: extragear/libs/kipi-plugins)

Fabien fabien.ubuntu at gmail.com
Fri Dec 8 17:26:21 CET 2006


Hi,

Fabien wrote:
> Angelo Naselli wrote:
> 
>>>Using my script (compile_digikam.txt
>>>http://www.digikam.org/?q=download/svn), it doesn't work (exiv2 is
>>>installed in a non-default directory).
>>>
>>>I had to use "export PKG_CONFIG_PATH=$DIGIKAMDEST/lib/pkgconfig" to make
>>>it work.
>>
>>That should be the right way to.

With the tests I made about digikam, exiv2 and local compilation when 
exiv2 is already installed in the system (see digikam-users ml), I know 
a bit more about all this stuff :)

So, about the problem I reported a few days ago, I think it would be 
better to use KDE_PKG_CHECK_MODULES instead of PKG_CHECK_MODULES in :
libs/kipi-plugins/configure.in.in for the exiv2 test.

It would be more consistent as it's already used by kipi-plugin test.
Like that, we don't need to define PKG_CONFIG_PATH anymore...


Here's the proposed patch :

Index: configure.in.in
===================================================================
--- configure.in.in     (revision 611531)
+++ configure.in.in     (working copy)
@@ -138,7 +138,7 @@
    AC_SUBST(EXIV2_CFLAGS)
    LIB_EXIV2="`$EXIV2_CONFIG --libs`"
    AC_SUBST(LIB_EXIV2)
-  PKG_CHECK_MODULES(EXIV2, exiv2 >= 0.12, have_exiv2=yes,have_exiv2=no)
+  KDE_PKG_CHECK_MODULES(EXIV2, exiv2 >= 0.12, have_exiv2=yes,have_exiv2=no)
  fi

  if test "x$have_exiv2" != "xyes"; then


--
Fabien



More information about the Kde-imaging mailing list