[Kde-imaging] [PATCH] Fixing copyright issue with KameraKlient plugin

Tom Albers tomalbers at kde.nl
Wed Apr 19 09:55:11 CEST 2006


Op Wednesday 19 April 2006 00:36, schreef Aurelien Gateau:
> Le Mardi 18 Avril 2006 23:48, Tom Albers a écrit :
> > Could you at least wait a full day before you commit?
> >
> > I have some problems with it. Much of the files seem to be derived work
> > from Renchi. At least that is what Achim is telling me on IRC. Only
> > Renchi did not care to add his name to the copyright headers.
> >
> > Besides that on certain files it is clear that Renchi is copyright
> > holder, for example:
> > http://cvs.sourceforge.net/viewcvs.py/digikam/digikam3/digikamcameraclien
> >t/ cameraui/savefiledialog.cpp?rev=1.2&view=log I dont understand why in
> > the patch there is Tudor mentioned in this case.
> >
> > I'm not sure what to do, as both are unreachable, I suggest to at least
> > add Renchi if he touched the files in svn at sf or kdesvn.
>
> I'm sorry, it's already committed.  You are right, I should have waited a
> bit more.
>
> It should be mostly ok nevertheless: Gilles pointed me to the Digikam CVS
> repository and I added Renchi as copyright holder for all copyright-less
> files which were in Digikam 0.6.2.  The following files are the ones which
> are assigned to Tudor only:
> - cameraselection.h
> - kameraklient.h
> - thumbitem.h
> - thumbview.h
> - cameraselection.cpp
> - kameraklient.cpp
> - thumbitem.cpp
> - thumbview.cpp

In the patch you posted here savefiledialog.cpp was Tudor only, while the cvs 
show it is a Renchi only. Did you change the patch before comitting or is 
there something else I dont understand yet?

Toma


More information about the Kde-imaging mailing list