[Kde-imaging] [Bug 89394] New: Make CDArchivingplugin work when ImageCollection!=Folder

[Jean-Michel Fayard]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
        
http://bugs.kde.org/show_bug.cgi?id=89394        
           Summary: Make CDArchivingplugin work when ImageCollection!=Folder
           Product: kipiplugins
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: cdarchiving
        AssignedTo: kde-imaging kde org
        ReportedBy: jmfayard gmail com


Version:            (using KDE KDE 3.2.3)
Installed from:    Compiled From Sources
Compiler:          gcc-3.4 -g 
OS:                Linux

Description : CDArchivingPlugin is broken for an application where ImageCollection!=Folder. The HTML generation doesn't work, and the original pictures which doesn't belong to the same directory as the first picture in the image collection are not burned.

How to reproduce it: 
Go to http://ktown.kde.org/kimdaba/snapshots/ and follow the installation procedure (doing export CFLAGS="-g " before is useful)
Copy the pictures attached right in your home directory and start Kimdaba
File>Archive to CD>Select all keywords, burn an iso in k3b and mount it with :
$ su
$ mount  -o loop -t iso9660 <temporary folder>/CD\ Albums.iso <empty directory>

Patch attached : some preliminary work, basically remplacing each QDir dir = ImageCollection::path() with the equivalent ImageCollection. This also change the directory structure of <cdrom>/<folder>/image.jpg to <cdrom>/<keyword>[1]/image.jpg

[1] : the name of the imagecollection in KimDaBa

Current problems :

* Maybe existing in the original plugin: pictures with latin1 characters doesn't show in HTML generation.
(/mnt/removable/HTMLInterface/inclassables/pages/28 - Mais oui elle est l%3F%3F, ma montre.JPG.html
instead of
/mnt/removable/HTMLInterface/inclassables/pages/28 - Mais oui elle est là, ma montre.JPG.html )

* Maybe existing in the original plugin : slow memory leak. KimDaBa used 95MB after generating a 600MO CD.

* For now, it doesn't try to copy recursively directories. I find it totally broken, because I have one picture in the top directory, it will copy all the top diretory, and then the others subdirectories again for the others keywords.

* Pictures can have many keywords in KimDaBa, so by design, one picture will be copied many times. Does K3B use symlink on a iso when it is possible (with Joliet or Rockridge, I don't know...) ?

* Note that because it now copies the images in a collection and not anymore all files in a folder, it cannot copy other files (comment.xml or whatever) in the directory. If this is a problem, we can use the new ImageCollection::isDirectory() and switch back to the old behaviour.

* Need to try it, and perhaps to make it work again with Digikam


That's all for now ;-)