[Kde-imaging] PATCH: imagegalleries.cpp

[Dawit A.]

Hello,

The attached patch fixes one annoying problem I had withe the HTML export and 
cleans up few things:

-  When doing HTML export, do not append a file extension if the file already 
ends with that extension!

- Do not temporarily create and destory short lived objects. It costs too 
much. For example, there is no reason to have a KConfig member variable if 
it's you are going to simply create and delete it at the beginning and end of 
a function.

- No need to do  "if (object) delete object;" if you properly initialized the 
object...

- Is there anyway the indentation in each file could be kept in a sane 
manner ? It is really hard to follow code when the indentation changes from 
line to line. This file had three different indentation styles!!! One I have 
never encountered before:

if (.....)
   {
    ...
   }

I personally do not care which one gets used, but please stick to one in the 
same file. Please CC me as I am not subscribed to either mailing list...

-- 
Regards,
Dawit A.
"Preach what you practice, practice what you preach"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: imagegalleries.diff
Type: text/x-diff
Size: 21584 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-imaging/attachments/20041030/b48f5c93/imagegalleries.bin